Date: Fri, 07 Nov 1997 15:13:51 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Eivind Eklund <perhaps@yes.no> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 machdep.c pmap.c src/sys/i386/isa if_zp.c ncr5380.c seagate.c syscons.c wd.c src/sys/kern subr_diskslice.c src/sys/libkern qdivrem.c src/sys/netinet ip_output.c src/sys/nfs nfs_vnops.c src/sys/pci ncr.c src/sys/vm ... Message-ID: <2568.878912031@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 07 Nov 1997 15:09:48 %2B0100." <199711071409.PAA07017@bitbox.follo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199711071409.PAA07017@bitbox.follo.net>, Eivind Eklund writes: >[...] >> Log: >> Rename some local variables to avoid shadowing other local variables. >> >> Found by: -Wshadow > >If you've fixed all of these, would it be a good idea to add -Wshadow >and -Wunused to the Makefile flags? Well, I just took the easy ones, there are plenty still to go. For -Wunused, many variables should go under some #ifdef FOOMBLE option which is present i LINT but not in GENERIC For -Wshadow, there are some not quite easy to fix systematic shadowing going on. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2568.878912031>