Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Dec 2017 10:53:14 +0000 (UTC)
From:      Raphael Kubo da Costa <rakuco@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r457276 - in head/devel/qt5-assistant: . files
Message-ID:  <201712261053.vBQArEPg033733@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rakuco
Date: Tue Dec 26 10:53:13 2017
New Revision: 457276
URL: https://svnweb.freebsd.org/changeset/ports/457276

Log:
  Drop dependency on www/qt5-webkit.
  
  Reduce qt5-assistant's dependency tree by dropping the dependency on QtWebKit.
  Instead, use qt5-widgets' QTextBrowser to render documentation. An added bonus
  is that with this change www/qt5-webengine no longer depends on www/qt5-webkit.
  
  Page rendering is slightly worse, but everything is still very much readable.
  
  Reviewed by:	tcberner
  Differential Revision:	https://reviews.freebsd.org/D13630

Added:
  head/devel/qt5-assistant/files/patch-src_assistant_assistant_assistant.pro   (contents, props changed)
Modified:
  head/devel/qt5-assistant/Makefile

Modified: head/devel/qt5-assistant/Makefile
==============================================================================
--- head/devel/qt5-assistant/Makefile	Tue Dec 26 10:50:37 2017	(r457275)
+++ head/devel/qt5-assistant/Makefile	Tue Dec 26 10:53:13 2017	(r457276)
@@ -2,13 +2,14 @@
 
 PORTNAME=	assistant
 DISTVERSION=	${QT5_VERSION}
+PORTREVISION=	1
 CATEGORIES=	devel
 PKGNAMEPREFIX=	qt5-
 
 MAINTAINER=	kde@FreeBSD.org
 COMMENT=	Qt 5 documentation browser
 
-USE_QT5=	core gui help network printsupport sql webkit widgets \
+USE_QT5=	core gui help network printsupport sql widgets \
 		buildtools_build sql-sqlite3_run
 QT_DIST=	tools
 USES=		qmake

Added: head/devel/qt5-assistant/files/patch-src_assistant_assistant_assistant.pro
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/qt5-assistant/files/patch-src_assistant_assistant_assistant.pro	Tue Dec 26 10:53:13 2017	(r457276)
@@ -0,0 +1,13 @@
+Do not use QtWebKit even if it is present to reduce the port's dependencies.
+--- src/assistant/assistant/assistant.pro
++++ src/assistant/assistant/assistant.pro
+@@ -1,8 +1,4 @@
+-qtHaveModule(webkitwidgets):!contains(QT_CONFIG, static) {
+-    BROWSER = qtwebkit
+-} else {
+-    BROWSER = qtextbrowser
+-}
++BROWSER = qtextbrowser
+ 
+ QT += widgets network help sql help
+ qtHaveModule(printsupport): QT += printsupport



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712261053.vBQArEPg033733>