Date: Tue, 29 Jun 2004 08:13:11 -0400 (EDT) From: Andrew Gallatin <gallatin@cs.duke.edu> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/vm vm_map.c Message-ID: <16609.23767.245708.270218@grasshopper.cs.duke.edu> In-Reply-To: <20040629114614.T2908@gamplex.bde.org> References: <200406281915.i5SJFeaV060231@repoman.freebsd.org> <20040628152232.A2977@grasshopper.cs.duke.edu> <20040628193858.GG5635@green.homeunix.org> <16608.30892.745161.730935@grasshopper.cs.duke.edu> <20040629114614.T2908@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans writes:
> On Mon, 28 Jun 2004, Andrew Gallatin wrote:
>
> > Brian Fundakowski Feldman writes:
> > > On Mon, Jun 28, 2004 at 03:22:33PM -0400, Andrew Gallatin wrote:
> > > > Andrew Gallatin [gallatin@FreeBSD.org] wrote:
> > > > > gallatin 2004-06-28 19:15:40 UTC
> > > > >
> > > > > FreeBSD src repository
> > > > >
> > > > > Modified files:
> > > > > sys/vm vm_map.c
> > > > > Log:
> > > > > Fix alpha - the use of min() on longs was loosing the high bits and
> > > > > returning wrong answers, leading to strange values vm2->vm_{s,t,d}size.
>
> MIN() and MAX() should not be used in the kernel. 4.4BSD removed them in
> the kernel, but FreeBSD broke this in rev.1.141 of sys/param.h. They
> remain removed in RELENG_4.
>
OK. Then what's the correct fix? ulmin()?
Thanks,
Drew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16609.23767.245708.270218>