Date: Thu, 7 Jul 2016 07:56:38 -0700 From: Maxim Sobolev <sobomax@freebsd.org> To: Paul Mather <paul@gromit.dlib.vt.edu>, Luiz Otavio O Souza <loos.br@gmail.com> Cc: Keith White <kwhite@site.uottawa.ca>, "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: BBB (cpsw(4)) seems to be broken in the latest 11-current Message-ID: <CAH7qZfuCkbiwPyjuZcB=cH54ekQ4sr2VDr1tdHnpJJX-_PVE7w@mail.gmail.com> In-Reply-To: <DB254FD5-E729-4E1B-881D-ABB61C0FED39@gromit.dlib.vt.edu> References: <CAH7qZfsMiUSCTG827ysO89o9nH9WAKu4w%2BiZPZ-UKKVa6T2pcA@mail.gmail.com> <CAFHCsPWUFDiM%2BQh6EkNKPdbm0BrqtgStdzig4WyFmj8L31qN%2Bg@mail.gmail.com> <CAH7qZftdjhrp_m440BPHeArSnV-QQmghm4UyMJ3qro75NMGPQA@mail.gmail.com> <83A18C0E-FA89-4009-A8D5-3185FB27A688@netgate.com> <CAH7qZfvRB4y=GP9yjCAjjBy2h3pHTifdm0t%2BTTVFONQNPe9=8w@mail.gmail.com> <CAH7qZfvAh-dSRYM7G1BkpgMZc3zkeSDakj7LOO=s2JF%2BUy=eUw@mail.gmail.com> <CAJ8CS7qEAjhON6vBL2%2Bh5u=EOK20jnSFzRV1%2BsF3a-GUhLjHoQ@mail.gmail.com> <alpine.BSF.2.20.1606201832030.52002@localhost.my.domain> <DB254FD5-E729-4E1B-881D-ABB61C0FED39@gromit.dlib.vt.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Luiz, the patch works for me beautifully. Has not been able to reproduce the issue since applying it. Can you please merge it before 11.0 gets branched? Thanks! -Max On Tue, Jun 21, 2016 at 10:33 AM, Paul Mather <paul@gromit.dlib.vt.edu> wrote: > On Jun 20, 2016, at 6:33 PM, Keith White <kwhite@site.uottawa.ca> wrote: > > > On Mon, 20 Jun 2016, Luiz Otavio O Souza wrote: > > > >> On Sun, Jun 19, 2016 at 1:11 AM, Maxim Sobolev wrote: > >>> Jim, some update from here. Running r283287 of the driver, I still see > the > >>> same "watchdog timeout" messages, but they do not lead to the interface > >>> lockout. The traffic resumes momentarily. Which is probably why I > never paid > >>> much attention to those warnings before. Therefore, I suspect that the > new > >>> MAC code does not deal with watchdog-triggered interface reset as good > as > >>> the old code. Does it give you any ideas about what could be wrong > there by > >>> any chance? > >> > >> > >> Hi Maxim, > >> > >> My recent changes contributed somehow to expose the bug more frequently. > >> > >> There was a condition in tx packet reclamation where we aren't > >> restarting the tx queue in one of the possible stall conditions. > >> > >> Please try the attached patch and let me know if it works for you. > >> > >> Luiz > > > > Your patch fixes the problem for me. Thanks! > > > > FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #0 r302028M: Mon Jun > 20 18:19:55 EDT 2016 kwhite@freebsd11:/usr/obj/arm.armv6/usr/src/sys/BEAGLEBONE-LOCAL > arm armv6 > > > > ...keith > > > The patch also fixes the problem for me. > > FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #2 r302030M: Tue Jun 21 > 10:20:59 EDT 2016 pmather@beaglebone:/usr/obj/usr/src/sys/BEAGLEBONE-NO_WITNESS > arm > > > Cheers, > > Paul. > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAH7qZfuCkbiwPyjuZcB=cH54ekQ4sr2VDr1tdHnpJJX-_PVE7w>