Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 02 Jun 2009 17:14:16 +0300
From:      Andriy Gapon <avg@freebsd.org>
To:        Henri Hennebert <hlh@restart.be>, Kip Macy <kmacy@freebsd.org>
Cc:        freebsd-current@freebsd.org, freebsd-stable@freebsd.org
Subject:   Re: libzpool assert vs libc assert
Message-ID:  <4A2533B8.8040007@freebsd.org>
In-Reply-To: <4A2531DA.2070608@freebsd.org>
References:  <3c1674c90905201643m540c8b1v8a8bd88f071c233d@mail.gmail.com>		<4A1D0F2B.4030006@restart.be>		<ed91d4a80905271104g2a824d0fna004d1c4f3126c67@mail.gmail.com>	<3c1674c90905280052q281f6172j2409fe2d64db6914@mail.gmail.com> <4A1E90F7.2000000@restart.be> <4A1E97D8.4080901@icyb.net.ua> <4A1FD687.5070502@freebsd.org> <4A23EEC8.2040208@freebsd.org> <4A23FDE5.1040101@restart.be> <4A240063.207@freebsd.org> <4A2531DA.2070608@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
on 02/06/2009 17:06 Andriy Gapon said the following:
> So I am quite sure that mutex_owned should be defined as follows:
> #define  mutex_owned(l)          pthread_mutex_isowned_np((l)->m_lock)

Actually:
#define  mutex_owned(l)          pthread_mutex_isowned_np(&(l)->m_lock)

And on dangers of ignored compiler warnings:
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu.c:606:
warning: passing argument 6 of 'dmu_buf_hold_array' discards qualifiers from
pointer target type
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c:264:
warning: passing argument 1 of 'pthread_mutex_isowned_np' from incompatible
pointer type
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c:267:
warning: passing argument 1 of 'pthread_mutex_isowned_np' from incompatible
pointer type
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c:270:
warning: passing argument 1 of 'pthread_mutex_isowned_np' from incompatible
pointer type
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu.c:606:
warning: passing argument 6 of 'dmu_buf_hold_array' discards qualifiers from
pointer target type
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c:264:
warning: passing argument 1 of 'pthread_mutex_isowned_np' from incompatible
pointer type
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c:267:
warning: passing argument 1 of 'pthread_mutex_isowned_np' from incompatible
pointer type
/usr/src-head/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c:270:
warning: passing argument 1 of 'pthread_mutex_isowned_np' from incompatible
pointer type

This is during libzpool compilation.

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A2533B8.8040007>