Date: Sun, 15 Jul 2018 18:03:57 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r336311 - head/sys/dev/ixgbe Message-ID: <201807151803.w6FI3vJu009799@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: marius Date: Sun Jul 15 18:03:56 2018 New Revision: 336311 URL: https://svnweb.freebsd.org/changeset/base/336311 Log: Remove code to disable IFCAP_VLAN_HWFILTER by default for ixgbe(4) as VLAN events are passed through by lagg(4) ever since r203548. Deactivation of this capability by default due to lagg(4) was already not done for ixgbev(4) and has been - although inadvertently - broken when em(4)/igb(4)/lem(4) and ixl(4) were converted to iflib(9) in r311849 and r335338 respectively. Reviewed by: erj Differential Revision: https://reviews.freebsd.org/D15720 (part of) Modified: head/sys/dev/ixgbe/if_ix.c Modified: head/sys/dev/ixgbe/if_ix.c ============================================================================== --- head/sys/dev/ixgbe/if_ix.c Sun Jul 15 18:03:19 2018 (r336310) +++ head/sys/dev/ixgbe/if_ix.c Sun Jul 15 18:03:56 2018 (r336311) @@ -1180,15 +1180,6 @@ ixgbe_setup_interface(if_ctx_t ctx) adapter->max_frame_size = ifp->if_mtu + ETHER_HDR_LEN + ETHER_CRC_LEN; - /* - * Don't turn this on by default, if vlans are - * created on another pseudo device (eg. lagg) - * then vlan events are not passed thru, breaking - * operation, but with HW FILTER off it works. If - * using vlans directly on the ixgbe driver you can - * enable this and get full hardware tag filtering. - */ - if_setcapenablebit(ifp, 0, IFCAP_VLAN_HWFILTER); adapter->phy_layer = ixgbe_get_supported_physical_layer(&adapter->hw); ixgbe_add_media_types(ctx);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807151803.w6FI3vJu009799>