Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Sep 2018 20:32:09 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r338841 - head/sys/amd64/amd64
Message-ID:  <201809202032.w8KKW96K032454@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Thu Sep 20 20:32:08 2018
New Revision: 338841
URL: https://svnweb.freebsd.org/changeset/base/338841

Log:
  amd64: macroify copyin/copyout and provide erms variants, follow up
  
  Fix a fat-fingered typo with a "funny" side-effect: when doing copyin on a
  cpu without ERMS and with size being a multiply of 8 a page fault would be
  triggered resulting in EFAULT.
  
  Pointy hat: mjg
  Approved by:	re (implicit)

Modified:
  head/sys/amd64/amd64/support.S

Modified: head/sys/amd64/amd64/support.S
==============================================================================
--- head/sys/amd64/amd64/support.S	Thu Sep 20 20:06:44 2018	(r338840)
+++ head/sys/amd64/amd64/support.S	Thu Sep 20 20:32:08 2018	(r338841)
@@ -410,7 +410,7 @@ copyout_fault:
 	movsq
 	movb	%al,%cl
 	andb	$7,%cl				/* copy remaining bytes */
-	je	1
+	je	1f
 .endif
 	rep
 	movsb



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809202032.w8KKW96K032454>