Date: Thu, 10 Jun 2021 14:18:32 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> To: Ceri Davies <ceri@submonkey.net> Cc: Ian Lepore <ian@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: Inclusion of all manual pages in all architecture releases Message-ID: <CAGwOe2Y2kWrgRNGFfh42JwbJTXkZEOmQ5FFNhRKaNPK3Wp3%2BpQ@mail.gmail.com> In-Reply-To: <YLUMNPVL7q1kHJVR@submonkey.net> References: <CAGwOe2YTOCgak-CpEy4aa=vHseOMu6wjVF8JTV_0z=5WGkYFYg@mail.gmail.com> <e04c556294e471c0fa9db8bd105f1333e2340f29.camel@freebsd.org> <CAGwOe2aE5LOei8Qq0N6-LYViL-xQF52-qHpruVPYyZ3bt%2BmOMw@mail.gmail.com> <20210531070722.GR14975@funkthat.com> <YLUMNPVL7q1kHJVR@submonkey.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 31, 2021 at 6:17 PM Ceri Davies <ceri@submonkey.net> wrote:
>
> On Mon, May 31, 2021 at 12:07:22AM -0700, John-Mark Gurney wrote:
> > Fernando Apestegua wrote this message on Thu, May 27, 2021 at 08:40 +0200:
> > >
> > > Hi Ian,
> > >
> > > Thanks for the explanation. That would fix the man.cgi and
> > > consequently the Release Notes issues.
> > > However, in order to fix the broken X-refs in the manual pages of the
> > > release distributions, wouldn't we need to build them with
> > > MAN_ARCH=all?
> > > According to make.conf(5), MAN_ARCH defaults to MACHINE and
> > > MACHINE_ARCH. Would it be possible to change the default value to
> > > "all"?
> > >
> > > diff --git a/share/man/man4/Makefile b/share/man/man4/Makefile
> > > index f7626c80eeb1..583c4a4b9bb9 100644
> > > --- a/share/man/man4/Makefile
> > > +++ b/share/man/man4/Makefile
> > > @@ -897,9 +897,7 @@ _cgem.4= cgem.4
> > > MLINKS+=cgem.4 if_cgem.4
> > > .endif
> > >
> > > -.if empty(MAN_ARCH)
> > > -__arches= ${MACHINE} ${MACHINE_ARCH} ${MACHINE_CPUARCH}
> > > -.elif ${MAN_ARCH} == "all"
> > > +.if empty(MAN_ARCH) || ${MAN_ARCH} == "all"
> > > __arches= ${:!/bin/sh -c "/bin/ls -d ${.CURDIR}/man4.*"!:E}
> > > .else
> > > __arches= ${MAN_ARCH}
> > >
> > > This way, the released distributions will have all the man pages (we
> > > have some PRs related to this) and would also fix man.cgi regardless
> > > of the FreeBSD version the service runs on.
> > >
> > > I am assuming here that we do not explicitly set MAN_ARCH to a
> > > specific architecture when building the releases but we take the
> > > default value.
> >
> > I would like to see this change made myself. It'd nice to be able to
> > use your amd64 build box to be able to get information on other systems
> > by default. The extra space is minimal.
>
> Agreed. I would prefer if architecture specific pages went into their
> own section, and were then hardlinked into the existing architecture's
> standard sections (this would preserve current behaviour, and allow each
> architecture its own namespace if needed).
I created https://reviews.freebsd.org/D30715 and took the liberty of
adding some of you who provided feedback, to the review.
Thanks!
>
> Ceri
> --
> That must be wonderful! I don't understand it at all.
> -- Moliere
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2Y2kWrgRNGFfh42JwbJTXkZEOmQ5FFNhRKaNPK3Wp3%2BpQ>