Date: Tue, 27 Nov 2018 13:00:07 -0600 From: "David A. Bright" <david@bright-family.net> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341068 - head/tests/sys/kqueue/libkqueue Message-ID: <74f6433b-08ed-c6b3-fd23-8bb97719b56b@FreeBSD.org> In-Reply-To: <CAG6CVpVfXdz1paTytNjvyV8A9-0dZ28g7GXrogcmHCnmyp3A1g@mail.gmail.com> References: <201811271512.wARFCYmP092105@repo.freebsd.org> <CAG6CVpVfXdz1paTytNjvyV8A9-0dZ28g7GXrogcmHCnmyp3A1g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/27/18 12:34 PM, Conrad Meyer wrote: > As long as we were correcting indentation whitespace, it seems like it > would have been good to go to tabs, per style(9), instead of spaces. > Or are these considered contrib code from NetBSD? A fair question. I'm not sure whether they should be considered contrib code or not. As the (vast?) majority the tab-using lines were from prior changes that I made, I thought I should return the files to their original spaces-instead-of-tabs, 4-space indent format on the theory that I should have recognized and matched the existing style in the first place. Not to mention that this change was much smaller and less disruptive; if I had converted the files to style(9), most lines in the files would have had to change. -- David Bright dab@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?74f6433b-08ed-c6b3-fd23-8bb97719b56b>