Date: Wed, 03 Apr 2002 07:21:09 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: arch@FreeBSD.ORG Subject: Re: Please review: endian invariant kernel dump headers Message-ID: <27395.1017811269@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 02 Apr 2002 19:42:08 -0800." <20020403034208.GA929@dhcp01.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020403034208.GA929@dhcp01.pn.xcllnt.net>, Marcel Moolenaar writes : >Please review the attached patch. The change achieves the following: > >1. Dump the kernel header in dump byte order. This is the same > as network byte order. Parity calculation is endianness > invariant and should not use the macros. good. >2. The kernel dump header had a size of 520 bytes on 64-bit > architectures due to alignment of the uint64_t following > the uint32_t. Reordering solves that. My fault, I thought I had that right. >3. No version bump is required, because all existing headers are > in little-endian and thus will not have the same version as > the big-endian dumps. I did not add support in savecore to > read version 0x01000000 headers :-) Cool. Suggest you add: CTASSERT(sizeof kerneldumpheader == 512); while at it. >If there are no blocking objections I like to commit this quickly >due to point 2. By all means. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?27395.1017811269>