Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Jan 2014 07:53:19 +0000
From:      Max Brazhnikov <makc@freebsd.org>
To:        Raphael Kubo da Costa <rakuco@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r340198 - in head/textproc/sigil: . files
Message-ID:  <4078889.Pc4XLY34Bx@mercury.ph.man.ac.uk>
In-Reply-To: <201401181756.s0IHulHB067303@svn.freebsd.org>
References:  <201401181756.s0IHulHB067303@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 18 Jan 2014 17:56:47 +0000Sat Jan 18 17:56:47 2014 Raphael Kubo da Costa wrote:
> Author: rakuco
> Date: Sat Jan 18 17:56:47 2014
> New Revision: 340198
> URL: http://svnweb.freebsd.org/changeset/ports/340198
> QAT: https://qat.redports.org/buildarchive/r340198/
> 
> Log:
>   - Allow the port to build with archivers/libzip installed.
>     libzip installs /usr/local/include/zip.h, and -I/usr/local/include ended
>     up being passed to the compiler before -I<path-to-internal-minizip-copy>,
>     which caused problems. [1]
>   
>   While here, modernize the Makefile:
>   - Move LICENSE to the appropriate place.
>   - Remove USE_DOS2UNIX: the files it was supposed to fix are not DOS-encoded
>     anymore.
>   - Support staging.
>   - Convert from manually calling update-desktop-database and
>     USE_GNOME=desktopfileutils to USES=desktop-file-utils.
>   
>   PR:		ports/180350 [1]
>   Approved by:	maintainer timeout (no activity since the original report 7 months ago)
>   MFH:		2014Q1
> 
> Added:
>   head/textproc/sigil/files/patch-src_Sigil_CMakeLists.txt   (contents, props changed)
> Modified:
>   head/textproc/sigil/Makefile
> 
> Modified: head/textproc/sigil/Makefile
> ==============================================================================
> --- head/textproc/sigil/Makefile	Sat Jan 18 16:47:31 2014	(r340197)
> +++ head/textproc/sigil/Makefile	Sat Jan 18 17:56:47 2014	(r340198)
> @@ -11,25 +11,19 @@ DISTNAME=	Sigil-${PORTVERSION}-Code
>  MAINTAINER=	jonc@chen.org.nz
>  COMMENT=	WYSIWYG ePub editor
>  
> +LICENSE=	GPLv3
> +
>  LIB_DEPENDS=	libboost_thread.so:${PORTSDIR}/devel/boost-libs \
>  		libxerces-c.so:${PORTSDIR}/textproc/xerces-c3 \
>  		libhunspell-1.3.so:${PORTSDIR}/textproc/hunspell \
>  		libpcre.so:${PORTSDIR}/devel/pcre
>  
> -LICENSE=	GPLv3
> -
>  USE_ZIP=	yes
> -USES=		cmake pkgconfig
> -USE_DOS2UNIX=	CMakeLists.txt DirEnumerator.cpp ZipFile_stl.cpp ZipPlatform_lnx.cpp
> +USES=		cmake desktop-file-utils pkgconfig
>  NO_WRKSUBDIR=	yes
>  USE_QT4=	qmake gui svg webkit xml moc uic rcc imageformats linguist

Raphael,

You have missed the opportunity to add _build suffix to some Qt4 dependencies :)

Cheers,
Max



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4078889.Pc4XLY34Bx>