Date: Tue, 21 Feb 2006 11:40:31 +0900 From: Alexander Nedotsukov <bland@FreeBSD.org> To: Pascal Hofstee <caelian@gmail.com> Cc: gnome@FreeBSD.org Subject: Re: Eog Crash while opening jpeg-images with EXIF data Message-ID: <43FA7D9F.5090108@FreeBSD.org> In-Reply-To: <1140487656.847.6.camel@synergy.odyssey.homeunix.org> References: <1140487656.847.6.camel@synergy.odyssey.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Pascal, Cast it to (char*) instead. And this is not the only place in that file. You have to patch other memcpy()s too. All the best, Alexander. Pascal Hofstee wrote: > i am noticing a consistent eog crash when opening jpeg images with EXIF > data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT > > The line that causes the crash is libeog/eog-metadata-reader.c:231 > > memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read), > (void*)&buf[i], priv->size); > > I am about 99% sure the (int) typecast on priv->exit_chunk is truncating > the 64-bit pointer into 32-bits causing the application to segfault as a > result. I am not 100% on how to properly fix this. > > If any of you could have a look at this, that would be appreciated. > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43FA7D9F.5090108>