Date: Fri, 21 Sep 2018 00:43:37 +0300 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, mmacy@freebsd.org, Johannes M Dieterich <jmd@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src Message-ID: <CAKBkRUyzkw9Y=n3RLaANVSaj%2BRx5KYBU9LaFw-PFnEKbr86eow@mail.gmail.com> In-Reply-To: <20180920190614.GI99168@raichu> References: <201807150023.w6F0NBx1065422@repo.freebsd.org> <20180920155402.GF99168@raichu> <e0f71549-3ae2-05b2-b4e7-228ae39c7f3c@FreeBSD.org> <20180920190614.GI99168@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 20, 2018 at 10:06 PM Mark Johnston <markj@freebsd.org> wrote: > > On Thu, Sep 20, 2018 at 09:39:24AM -0700, John Baldwin wrote: > > On 9/20/18 8:54 AM, Mark Johnston wrote: > > > On Sun, Jul 15, 2018 at 12:23:11AM +0000, Matt Macy wrote: > > >> Author: mmacy > > >> Date: Sun Jul 15 00:23:10 2018 > > >> New Revision: 336299 > > >> URL: https://svnweb.freebsd.org/changeset/base/336299 > > >> > > >> Log: > > >> msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd > > >> > > >> This corresponds to the latest status (hasn't changed in 9+ > > >> years) from openbsd of ld80/ld128 powl, and source cpowf, cpow, > > >> cpowl (the complex power functions for float complex, double > > >> complex, and long double complex) which are required for C99 > > >> compliance and were missing from FreeBSD. Also required for > > >> some numerical codes using complex numbered Hamiltonians. > > >> > > >> Thanks to jhb for tracking down the issue with making > > >> weak_reference compile on powerpc. > > >> > > >> When asked to review, bde said "I don't like it" - but > > >> provided no actionable feedback or superior implementations. > > >> > > >> Discussed with: jhb > > >> Submitted by: jmd > > >> Differential Revision: https://reviews.freebsd.org/D15919 > > > > > > This seems to have broken the gcc build: > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/ > > > > > > /workspace/src/lib/msun/ld80/e_powl.c:275:1: error: floating constant exceeds range of 'long double' [-Werror=overflow] > > > if( y >= LDBL_MAX ) > > > ^~ > > > > Which architecture? i386 doesn't get build with i386-xtoolchain-gcc pending > > some patches I haven't yet posted for review related to the weirdness we do > > with floating point on i386. > > This is the -m32 build on amd64. I haven't tested it myself, but Mark > Millard noted that the issue might be fixed by a gcc update. > I suspect this. Each build is in a fresh created jail with the latest branch of packages from pkg.freebsd.org. At the beginning of (warning: 56MB file) https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/7262/consoleText There is: New packages to be INSTALLED: amd64-xtoolchain-gcc: 0.4_1 amd64-gcc: 6.4.0_2 mpfr: 4.0.1 gmp: 6.1.2 mpc: 1.1.0_1 amd64-binutils: 2.30_5,1 Number of packages to be installed: 6 Or is there a newer version of devel/amd64-gcc I am not aware? -- Li-Wen Hsu <lwhsu@FreeBSD.org> https://lwhsu.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUyzkw9Y=n3RLaANVSaj%2BRx5KYBU9LaFw-PFnEKbr86eow>