Date: Mon, 02 Jan 2006 10:25:34 +0100 From: Niclas Zeising <lothrandil@n00b.apagnu.se> To: Xin LI <delphij@freebsd.org> Cc: freebsd-doc@FreeBSD.org Subject: Re: [PATCH FOR REVIEW] doc/en_US.ISO8859-1/books SGML cleanup Message-ID: <43B8F18E.1010608@n00b.apagnu.se> In-Reply-To: <20060102101644.GA53576@hub.freebsd.org> References: <20060102101644.GA53576@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI wrote: > Dear folks, > > Recently one of our localization team member (intron@) has pointed > out to me that we have some unescaped >, <, and &'s found in the > SGML source. After some discussion we think that these changes > should be propagated back to the English version of these files > as well. > > Does the patch located at: > > http://people.freebsd.org/~delphij/for_review/patch-books > > Look appropriate? The primary change is to escape >, <, and &, plus > adding some "'s for attributes. > > Thanks for advance! > > Cheers, The patch looks, in my eyes, ok. I've only done a quick review of it. You have missed a lot of ">" though. It's in the various code listings, where you are accessing structure members through pointers with '->'. Nice work otherwise! //Niclas --
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43B8F18E.1010608>