Date: Tue, 1 Jun 2010 15:20:26 GMT From: Alex Deiter <alex.deiter@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/147287: [PATCH] sysutils/openipmi: support sensors for Sun Fire x64 systems Message-ID: <201006011520.o51FKQch078763@www.freebsd.org> Resent-Message-ID: <201006011530.o51FU2UR050135@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 147287 >Category: ports >Synopsis: [PATCH] sysutils/openipmi: support sensors for Sun Fire x64 systems >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Jun 01 15:30:02 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Alex Deiter >Release: 9.0-CURRENT/r208656 >Organization: N/A >Environment: FreeBSD x60.deiter.net.ru 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Mon May 31 16:52:15 MSD 2010 root@x60.deiter.net.ru:/usr/obj/usr/src/sys/X60 amd64 >Description: Patch from OpenIPMI CVS Repositories for Sun Fire x64 systems: http://openipmi.cvs.sourceforge.net/viewvc/openipmi/OpenIPMI/ChangeLog 2010-05-28 Corey Minyard <cminyard@mvista.com> * lib/sensor.c: Change the "share count" checking to check if share count is > 1, not > 0, because some silly machines set the value to one when they should set it to zero, and one is a silly setting. Without this patch OpenIPMI show incorrect name for discrete sensors on SunFire x64 systems. For eaxample: PS0/PRSNT1, but should be PS0/PRSNT. >How-To-Repeat: cd /usr/ports/sysutils/openipmi && make install >Fix: Please review proposed patch. Patch attached with submission follows: --- sysutils/openipmi/Makefile.orig 2010-06-01 19:03:45.814189232 +0400 +++ sysutils/openipmi/Makefile 2010-06-01 19:04:14.224406732 +0400 @@ -7,6 +7,7 @@ PORTNAME= openipmi PORTVERSION= 2.0.18 +PORTREVISION?= 1 CATEGORIES= sysutils MASTER_SITES= SF/${PORTNAME}/OpenIPMI%202.0%20Library/${PORTVERSION} DISTNAME= OpenIPMI-${PORTVERSION} --- sysutils/openipmi/files/patch-lib-sensor.c.orig 2010-06-01 19:03:34.384120606 +0400 +++ sysutils/openipmi/files/patch-lib-sensor.c 2010-05-28 18:52:06.799848413 +0400 @@ -0,0 +1,11 @@ +--- lib/sensor.c.orig 2010-05-28 18:51:20.949496519 +0400 ++++ lib/sensor.c 2010-05-28 18:51:37.079705617 +0400 +@@ -1438,7 +1438,7 @@ + s[p]->id_type = IPMI_ASCII_STR; + } + +- if (share_count) { ++ if (share_count > 1) { + /* Duplicate the sensor records for each instance. Go + backwards to avoid destroying the first one until we + finish the others. */ >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006011520.o51FKQch078763>