Date: Tue, 20 Jul 1999 12:52:24 -0600 From: Nate Williams <nate@mt.sri.com> To: Warner Losh <imp@village.org> Cc: Nate Williams <nate@mt.sri.com>, hosokawa@itc.keio.ac.jp (HOSOKAWA Tatsumi), mobile@FreeBSD.ORG Subject: Re: usr.sbin/pccard/pccardd change for "cardio" and "cardmem" Message-ID: <199907201852.MAA20790@mt.sri.com> In-Reply-To: <199907201754.LAA87429@harmony.village.org> References: <199907201518.JAA19388@mt.sri.com> <199907201331.WAA22907@afs.ntc.mita.keio.ac.jp> <199907201754.LAA87429@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> In message <199907201518.JAA19388@mt.sri.com> Nate Williams writes: > : Can you be more specific? When are these used? It has been my > : experience that too often 'broken cards' are in fact not broken, and the > : FreeBSD code is broken. Adding workarounds for (potentially) broken > : code is not a good fix. > > Assuming for the moment that pccardd's cis reading is somehow > inadequate, I think that this is a good enough fix. Fix for what? What is the fix for? Just adding keywords to fix 'buggy' cards is not a fix, it's (potentially) a hack to workaround bogus code in other parts of the system that might be easily fixed. Many of the 'fixes' in PAO were *easily* fixed with just a bit of time with the 'bad' cards. Making the already difficult to understand code bigger and more complex with fixes for broken existing code is just silly. Now, I'm not saying that this is the case, but in the past this was very often the case, so allow me a bit of conservatism in not allowing every new feature to fix 'broken code'. :) Nate ps. I agree that there are fixes in the patch, but the addition of the keywords are not fixes. In particule, the 'release' of IRQ is a fix, as I pointed out in the original email. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907201852.MAA20790>