Date: Thu, 1 Jun 2017 09:32:38 -0600 From: Alan Somers <asomers@freebsd.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, Brooks Davis <brooks@freebsd.org>, Ngie Cooper <ngie@freebsd.org>, Marcel Moolenaar <marcel@freebsd.org>, "Simon J. Gerraty" <sjg@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <CAOtMX2jogda9vzo-8PG6-YMk3kPjO8%2BhzLYGiZAMzFaepQc1-Q@mail.gmail.com> In-Reply-To: <78A8D734-A627-437D-AE63-BA94C543C36B@xcllnt.net> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <78A8D734-A627-437D-AE63-BA94C543C36B@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 1, 2017 at 9:11 AM, Marcel Moolenaar <marcel@xcllnt.net> wrote: > > On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) > <yaneurabeya@gmail.com> wrote: > > > On May 31, 2017, at 10:03 PM, Brooks Davis <brooks@FreeBSD.org> wrote: > > On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: > > Author: ngie > Date: Wed May 31 08:01:12 2017 > New Revision: 319295 > URL: https://svnweb.freebsd.org/changeset/base/319295 > > Log: > Update the usr.bin/mkimg golden test output files after ^/head@r319125 > > ^/head@r319125 changed the location of the backup pmbr, requiring the > output files to be regenerated, since they're binary disk dumps. > > The output files were regenerated with "make rebase"--fixed in > ^/head@r319294. > > > These should not be stored uuencoded. It serves no purpose other > than bloating the repo and causing spammy commit mails like this one > where we got a huge tail of garbage output. > > > Hi Brooks, > I=E2=80=99m not entirely sure why the files were uuencoded to be honest. = I think > that=E2=80=99s a good question for Marcel and some of the folks at Junipe= r, since > they wrote the tool/tests. > > > Result files used to start off as binary files. uuencoding is a given in > that case. I eventually switched to using hexdump -C, because that makes= it > easier to analyze and understand differences. The uuencoding was kept to > remain independent of version control system, file attributes and > end-of-line characteristics of the host machine: nothing more annoying th= at > checking out textual result files and have test failures because =E2=80= =98\n=E2=80=99 was > replaced by =E2=80=98\r\n=E2=80=99. > > Even if the files aren=E2=80=99t unencoded, there=E2=80=99s always someon= e who treats it as > spammy and a tail of garbage. It=E2=80=99s just a knee-jerk reaction to s= eeing > something that isn=E2=80=99t understood, I think. As such, there=E2=80=99= s no reason to > change =E2=80=94 in fact, changing would be bloating the repo. > > -- > Marcel Moolenaar > marcel@xcllnt.net If the files are binary, then why not store them as binary files? Subversion can handle that. That way the tests won't need to decode them, svn clients won't change their line endings, and commit mail won't include their diffs. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2jogda9vzo-8PG6-YMk3kPjO8%2BhzLYGiZAMzFaepQc1-Q>