Date: Wed, 1 Jul 2009 02:14:02 GMT From: Nathan Whitehorn <nwhitehorn@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/136206: [patch] OVERRIDE_LINUX_NONBASE_PORTS not honored Message-ID: <200907010214.n612E2PQ079446@www.freebsd.org> Resent-Message-ID: <200907010220.n612K28L002150@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 136206
>Category: ports
>Synopsis: [patch] OVERRIDE_LINUX_NONBASE_PORTS not honored
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jul 01 02:20:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Nathan Whitehorn
>Release: 8.0-CURRENT
>Organization:
University of Wisconsin
>Environment:
FreeBSD comporellon.tachypleus.net 8.0-CURRENT FreeBSD 8.0-CURRENT #20 r194939M: Thu Jun 25 01:54:40 CDT 2009 root@comporellon.tachypleus.net:/usr/obj/usr/src/sys/COMPORELLON amd64
>Description:
After the change to Fedora 10 as the default Linux base on -CURRENT, you get messages like this even if OVERRIDE_LINUX_NONBASE_PORTS is set to f8:
** Port marked as IGNORE: x11/linux-f8-xorg-libs:
bsd.linux-rpm.mk test failed: default package building at OSVERSION>=800076 was changed to linux-f10 ports, please define OVERRIDE_LINUX_NONBASE_PORTS to build other linux infrastructure ports
>How-To-Repeat:
>Fix:
This is due to over-enthusiastic application of curly braces in the test on line 70 of bsd.linux-rpm.mk. Instead of testing defined(${OVERRIDE_LINUX_NONBASE_PORTS}), it should test defined(OVERRIDE_LINUX_NONBASE_PORTS).
Patch attached with submission follows:
--- bsd.linux-rpm.mk.dist 2009-06-30 21:09:06.000000000 -0500
+++ bsd.linux-rpm.mk 2009-06-30 21:09:19.000000000 -0500
@@ -67,7 +67,7 @@
LINUX_DIST_VER?= 4
. else
LINUX_DIST_VER?= 10
-. if !defined(${OVERRIDE_LINUX_NONBASE_PORTS}) && \
+. if !defined(OVERRIDE_LINUX_NONBASE_PORTS) && \
${LINUX_DIST_VER} != 10
IGNORE= bsd.linux-rpm.mk test failed: default package building at OSVERSION>=800076 was changed to linux-f10 ports, please define OVERRIDE_LINUX_NONBASE_PORTS to build other linux infrastructure ports
. endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907010214.n612E2PQ079446>