Date: Wed, 13 Aug 2008 13:56:14 GMT From: Ed Schouten <ed@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 147297 for review Message-ID: <200808131356.m7DDuEm1047888@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=147297 Change 147297 by ed@ed_mekker on 2008/08/13 13:55:42 Remove this debugging warning I added to the pts(4) driver to spot misbehaving applications. We should eventually get rid of /dev/ptmx somewhere in FreeBSD 42.0, but because Linux binaries tend to use it and many badly written applications use it (KDE's Konsole being one), I'll remove the warning. Affected files ... .. //depot/projects/mpsafetty/sys/kern/tty_pts.c#7 edit Differences ... ==== //depot/projects/mpsafetty/sys/kern/tty_pts.c#7 (text+ko) ==== @@ -607,8 +607,6 @@ } #if defined(PTS_COMPAT) || defined(PTS_LINUX) -static int pts_warningcnt = 10; - static int ptmx_fdopen(struct cdev *dev, int fflags, struct thread *td, struct file *fp) { @@ -618,14 +616,6 @@ if (error != 0) return (error); - /* Raise a warning when a legacy PTY has been allocated */ - if (pts_warningcnt > 0) { - pts_warningcnt--; - printf("pid %d (%s) is using legacy pts allocation%s\n", - td->td_proc->p_pid, td->td_name, - pts_warningcnt ? "" : " - not logging anymore"); - } - return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808131356.m7DDuEm1047888>