Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Mar 2017 19:30:22 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r316174 - head/sys/geom/mirror
Message-ID:  <201703291930.v2TJUMMK037081@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Wed Mar 29 19:30:22 2017
New Revision: 316174
URL: https://svnweb.freebsd.org/changeset/base/316174

Log:
  Remove an unneeded g_mirror_destroy_provider() call.
  
  The worker thread will destroy the mirror provider as part of its teardown
  sequence. The call made sense in the initial revision of gmirror, but
  became unnecessary in r137248.
  
  Tested by:	pho (part of a larger diff)
  MFC afteR:	2 weeks
  Sponsored by:	Dell EMC Isilon

Modified:
  head/sys/geom/mirror/g_mirror.c

Modified: head/sys/geom/mirror/g_mirror.c
==============================================================================
--- head/sys/geom/mirror/g_mirror.c	Wed Mar 29 19:25:42 2017	(r316173)
+++ head/sys/geom/mirror/g_mirror.c	Wed Mar 29 19:30:22 2017	(r316174)
@@ -2475,11 +2475,8 @@ g_mirror_update_device(struct g_mirror_s
 		if (g_mirror_ndisks(sc, G_MIRROR_DISK_STATE_ACTIVE) == 0 &&
 		    g_mirror_ndisks(sc, G_MIRROR_DISK_STATE_NEW) == 0) {
 			/*
-			 * No active disks or no disks at all,
-			 * so destroy device.
+			 * No usable disks, so destroy the device.
 			 */
-			if (sc->sc_provider != NULL)
-				g_mirror_destroy_provider(sc);
 			sc->sc_flags |= G_MIRROR_DEVICE_FLAG_DESTROY;
 			break;
 		} else if (g_mirror_ndisks(sc,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703291930.v2TJUMMK037081>