Date: Sun, 15 Oct 2000 13:39:20 -0700 From: Peter Wemm <peter@netplex.com.au> To: Alfred Perlstein <bright@wintelcom.net> Cc: Paul Saab <ps@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-disk.c src/sys/kern kern_shutdown.c src/sys/sys systm.h Message-ID: <200010152039.e9FKdKG51971@netplex.com.au> In-Reply-To: <20001015103014.H272@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein wrote: > * Paul Saab <ps@FreeBSD.org> [001015 02:45] wrote: > > ps 2000/10/15 02:45:24 PDT > > > > Modified files: (Branch: RELENG_4) > > sys/dev/ata ata-disk.c > > sys/kern kern_shutdown.c > > sys/sys systm.h > > Log: > > MFC: Do not allocate a callout for all crashdumps. > > Can you explain exactly what that means? The commitlog for -current > was even less understandable. What problem does this solve? Is > it just an effeciency issue? No, if you call dumpsys() from ddb or some other circumstances other than as a result of a panic, addump() would allocate a timeout struct for each sector written. Eventually it would run out and panic again, aborting the crashdump. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010152039.e9FKdKG51971>