Date: Wed, 10 Jan 2018 09:20:05 -0800 From: John Baldwin <jhb@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327705 - head/stand/mips/beri/common Message-ID: <46003356.LuRHu4Xbkq@ralph.baldwin.cx> In-Reply-To: <CANCZdfq7CCUDjNQCs9Uyj6ocmM_=KwhCdexU_DJr=E_AnyoZig@mail.gmail.com> References: <201801081847.w08IlZ7F033684@repo.freebsd.org> <1620808.I0a57TDRna@ralph.baldwin.cx> <CANCZdfq7CCUDjNQCs9Uyj6ocmM_=KwhCdexU_DJr=E_AnyoZig@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, January 09, 2018 10:48:30 AM Warner Losh wrote: > On Tue, Jan 9, 2018 at 10:05 AM, John Baldwin <jhb@freebsd.org> wrote: > > > On Monday, January 08, 2018 12:02:09 PM Warner Losh wrote: > > > This should have been a nop... libsa specifically creates 'safe' headers > > > for all the standard ones. > > > > > > Ah, libsa creates a perfectly fine stdint.h, but not a inttypes.h... > > > > Would you prefer it to use stdint.h and stdio.h rather than stand.h? > > > No. stand.h is fine. I just wondered why you hit issues at all with > stdio.h. inttypes.h isn't supported because we don't implement the extra > functions defined there over stdint.h, so it should have given an error > when included. I'm just surprised I didn't catch it in my universe.sh > script that I use to build all loaders though... FWIW, compiling with external GCC did not trip over this (so in-tree GCC probably didn't either). Only compiling with clang (for which I still have some out-of-tree patches) tripped over this. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46003356.LuRHu4Xbkq>