Date: Thu, 28 Sep 2006 00:32:18 -0700 From: Eric Anholt <anholt@FreeBSD.org> To: Joel Dahl <joel@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci agp_i810.c Message-ID: <1159428738.960.1.camel@vonnegut> In-Reply-To: <1159428160.671.35.camel@localhost> References: <200609270638.k8R6csJ0044991@repoman.freebsd.org> <1159423952.671.11.camel@localhost> <1159428160.671.35.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-+33X+IFlYHGitWJswzD6 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2006-09-28 at 09:22 +0200, Joel Dahl wrote: > On Thu, 2006-09-28 at 08:12 +0200, Joel Dahl wrote: > > On Wed, 2006-09-27 at 06:38 +0000, Eric Anholt wrote: > > > anholt 2006-09-27 06:38:54 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > sys/pci agp_i810.c=20 > > > Log: > > > Add support for 945G/GM AGP chipsets. > > > =20 > > > The key problem was that the aperture size detection using the MSAC= bit > > > doesn't work -- the bit appears to be set even when it shouldn't be= . Linux > > > takes a different approach, testing for a bit of the GMADR (PCIR_BA= R(2)) being > > > set. However, as I don't think that's a safe way to test aperture = size, we > > > just allocate the resource and check its size. This also pointed o= ut that > > > agp_generic_attach hadn't been allocating our aperture resource, wh= ich may > > > have caused problems in some cases. > > > =20 > > > Also corrected is a minor copy-and-pasteo in an error case. > >=20 > > Hmm, I have a HP NX7400 laptop with an Intel i945 chipset, and it's > > running a very fresh current (GENERIC, no changes made whatsoever). > > However, I see the following in my dmesg when I start X (I *think* it > > started appearing just after your commit to agp_i810.c): >=20 > Ok, I can confirm that reverting back to revision 1.38 of agp_i810.c > fixes the problem. Right, with no AGP support, you don't get DRM support, so you don't hit the path in the DRM with the witness warning. I'm not sure what to do about that warning yet :/ --=20 Eric Anholt anholt@FreeBSD.org eric@anholt.net eric.anholt@intel.com --=-+33X+IFlYHGitWJswzD6 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBFG3qBHUdvYGzw6vcRAs+EAJ0QzZj1/rONCxSJSKaHLjEIayYh6wCeO/bk FA8jEcWebTovnDdGztIz5C4= =zON5 -----END PGP SIGNATURE----- --=-+33X+IFlYHGitWJswzD6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1159428738.960.1.camel>