Date: Fri, 10 Sep 2004 11:53:47 +0200 From: Tijl Coosemans <tijl@ulyssis.org> To: freebsd-mobile@freebsd.org Subject: Re: [PATCH] ToPIC95B cardbus on old laptop Message-ID: <20040910115347.03a7b2ba.tijl@ulyssis.org> In-Reply-To: <200409090735.i897ZtuT005531@grimreaper.grondar.org> References: <200409040005.03105.tijl@ulyssis.org> <200409090735.i897ZtuT005531@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --Multipart=_Fri__10_Sep_2004_11_53_47_+0200_m87LKLjYSOOhXU7b Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 09 Sep 2004 08:35:55 +0100, Mark Murray wrote: > Could you please post the updated, working patch to the > freebsd-mobile@ list, with a honking great-big "[PATCH]" in the > subject so it doesn't get lost. Here it is. It addresses cardbus memory allocation for non-acpi laptops. However, as mentioned in the original patch at <http://www.freebsd.org/cgi/query-pr.cgi?pr=66848>; this might not be a clean solution. Quoting Warner Losh: ``The real issue is that the non acpi pcib driver doesn't restrict the memory ranges like it should, causing the allocation of 0!'' This patch adds a workarround in the cardbus driver, but the actual problem might not be there. --Multipart=_Fri__10_Sep_2004_11_53_47_+0200_m87LKLjYSOOhXU7b Content-Type: text/plain; name="pccbb.patch" Content-Disposition: attachment; filename="pccbb.patch" Content-Transfer-Encoding: base64 LS0tIHN5cy9kZXYvcGNjYmIvcGNjYmJfcGNpLmMub3JpZwlGcmkgU2VwIDEwIDExOjI2OjAyIDIw MDQKKysrIHN5cy9kZXYvcGNjYmIvcGNjYmJfcGNpLmMJRnJpIFNlcCAxMCAxMTozMjoyMyAyMDA0 CkBAIC0yODcsNiArMjg3LDM5IEBACiB9CiAKIHN0YXRpYyBpbnQKK2NiYl9wY2lfZ2V0X21lbW9y eShkZXZpY2VfdCBicmRldiwgaW50ICpyaWQpCit7CisJc3RydWN0IGNiYl9zb2Z0YyAqc2M7CisJ dV9pbnQzMl90IHNvY2tiYXNlOworCisJc2MgPSAoc3RydWN0IGNiYl9zb2Z0YyAqKSBkZXZpY2Vf Z2V0X3NvZnRjKGJyZGV2KTsKKwlzb2NrYmFzZSA9IHBjaV9yZWFkX2NvbmZpZyhicmRldiwgKnJp ZCwgNCk7CisJaWYgKHNvY2tiYXNlID49IDB4MTAwMDAwICYmIHNvY2tiYXNlIDwgMHhmZmZmZmZm MCkgeworCQlkZXZpY2VfcHJpbnRmKGJyZGV2LCAiQ291bGQgbm90IG1hcCByZWdpc3RlciBtZW1v cnkgMHgleFxuIiwKKwkJICAgIHNvY2tiYXNlKTsKKwkJcmV0dXJuIChFTk9NRU0pOworCX0KKwlw Y2lfd3JpdGVfY29uZmlnKGJyZGV2LCAqcmlkLCAweGZmZmZmZmZmLCA0KTsKKwlzb2NrYmFzZSA9 IHBjaV9yZWFkX2NvbmZpZyhicmRldiwgKnJpZCwgNCk7CisJc29ja2Jhc2UgPSAoc29ja2Jhc2Ug JiAweGZmZmZmZmYwKSAmIC0oc29ja2Jhc2UgJiAweGZmZmZmZmYwKTsKKyNkZWZpbmUgQ0JCX1NZ U19SRVNfTUVNT1JZX0VORCAgICAgICAgMHhGRkZGRkZGRgorCXNjLT5iYXNlX3JlcyA9IGJ1c19n ZW5lcmljX2FsbG9jX3Jlc291cmNlKGRldmljZV9nZXRfcGFyZW50KGJyZGV2KSwKKwkgICAgYnJk ZXYsIFNZU19SRVNfTUVNT1JZLCByaWQsCisJICAgIGNiYl9zdGFydF9tZW0sIENCQl9TWVNfUkVT X01FTU9SWV9FTkQsCisJICAgIHNvY2tiYXNlLCBSRl9BQ1RJVkUgfCBybWFuX21ha2VfYWxpZ25t ZW50X2ZsYWdzKHNvY2tiYXNlKSk7CisJaWYgKHNjLT5iYXNlX3JlcyA9PSBOVUxMKSB7CisJCWRl dmljZV9wcmludGYoYnJkZXYsICJDb3VsZCBub3QgZ3JhYiByZWdpc3RlciBtZW1vcnlcbiIpOwor CQlyZXR1cm4gKEVOT01FTSk7CisJfQorCXNvY2tiYXNlID0gcm1hbl9nZXRfc3RhcnQoc2MtPmJh c2VfcmVzKTsKKwlwY2lfd3JpdGVfY29uZmlnKGJyZGV2LCAqcmlkLCBzb2NrYmFzZSwgNCk7Cisj aWYgMAorCWRldmljZV9wcmludGYoYnJkZXYsICJQQ0kgTWVtb3J5IGFsbG9jYXRlZDogMHglMDh4 XG4iLCBzb2NrYmFzZSk7CisjZW5kaWYKKwlyZXR1cm4gKDApOworfQorCitzdGF0aWMgaW50CiBj YmJfcGNpX2F0dGFjaChkZXZpY2VfdCBicmRldikKIHsKIAlzdGF0aWMgaW50IGN1cnJfYnVzX251 bWJlciA9IDI7IC8qIFhYWCBFVklMRSBCQUQgKHNlZSBiZWxvdykgKi8KQEAgLTMxMiw2ICszNDUs MTIgQEAKIAlyaWQgPSBDQkJSX1NPQ0tCQVNFOwogCXNjLT5iYXNlX3JlcyA9IGJ1c19hbGxvY19y ZXNvdXJjZV9hbnkoYnJkZXYsIFNZU19SRVNfTUVNT1JZLCAmcmlkLAogCSAgICBSRl9BQ1RJVkUp OworCWlmIChzYy0+YmFzZV9yZXMgJiYgcm1hbl9nZXRfc3RhcnQoc2MtPmJhc2VfcmVzKSA8IDB4 YTAwMDApIHsKKwkJYnVzX3JlbGVhc2VfcmVzb3VyY2UoYnJkZXYsIFNZU19SRVNfTUVNT1JZLCBD QkJSX1NPQ0tCQVNFLAorCQkgICAgc2MtPmJhc2VfcmVzKTsKKwkJc2MtPmJhc2VfcmVzID0gTlVM TDsKKwkJY2JiX3BjaV9nZXRfbWVtb3J5KGJyZGV2LCAmcmlkKTsKKwl9CiAJaWYgKCFzYy0+YmFz ZV9yZXMpIHsKIAkJZGV2aWNlX3ByaW50ZihicmRldiwgIkNvdWxkIG5vdCBtYXAgcmVnaXN0ZXIg bWVtb3J5XG4iKTsKIAkJbXR4X2Rlc3Ryb3koJnNjLT5tdHgpOwo= --Multipart=_Fri__10_Sep_2004_11_53_47_+0200_m87LKLjYSOOhXU7b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040910115347.03a7b2ba.tijl>