Date: Mon, 22 Dec 2008 23:50:03 GMT From: "Garrett Cooper" <yanefbsd@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/129814: [patch] support of per script nice(1) value in periodic.conf(5) Message-ID: <200812222350.mBMNo3D7039264@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/129814; it has been noted by GNATS.
From: "Garrett Cooper" <yanefbsd@gmail.com>
To: "Artem Naluzhnyy" <tut@nhamon.com.ua>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/129814: [patch] support of per script nice(1) value in periodic.conf(5)
Date: Mon, 22 Dec 2008 15:44:22 -0800
The only issue with this is that:
if [ -n "${_nice}" ]
and:
elif [ -n "${default_nice}" ]
don't check for valid number values. I'm not sure if we'd want to
throw in that logic or not (or if there's something else in our
rc-scripts that automatically checks for numbers in range)...
I'd ask (quickly) on hackers@ to see if the change makes sense for a
more widespread review.
Cheers,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812222350.mBMNo3D7039264>