Date: Mon, 14 Aug 2006 20:26:03 +0800 From: Gea-Suan Lin <gslin@gslin.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: gslin@gslin.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports@freebsd.org Subject: Re: ports/101840: [PATCH] ftp/p5-Net-FTPServer: Respect DESTDIR Message-ID: <20060814122602.GA86906@gslin.org> In-Reply-To: <200608141059.k7EAx2ro062422@freefall.freebsd.org> References: <200608141059.k7EAx2ro062422@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, I disagree this opinion. DESTDIR should be considered previous events like importing SHA-256, @dirrmtry, and using USE_LDCONFIG to retire INSTALLS_SHLIB, ... etc. When upgrading or bug-fixing with respecting DESTDIR, the pr should not be splited into two parts. On Mon, Aug 14, 2006 at 10:59:02AM +0000, Mathieu Arnold wrote: > Synopsis: [PATCH] ftp/p5-Net-FTPServer: Respect DESTDIR > > State-Changed-From-To: open->closed > State-Changed-By: mat > State-Changed-When: Mon Aug 14 10:51:42 UTC 2006 > State-Changed-Why: > Committed in two parts, the DESTDIR, then the other things. I think that when > doing a DESTDIR change, you should not change anything not directly related to > it, to keep things simple. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=101840 -- * Gea-Suan Lin (public key: Using https://keyserver.pgp.com/ to search) * If you cannot convince them, confuse them. -- Harry S Truman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060814122602.GA86906>