Date: Fri, 30 Jan 2009 21:19:08 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Kostik Belousov <kostikbel@gmail.com> Cc: Tim Kientzle <kientzle@freebsd.org>, "'current@FreeBSD.org'" <current@freebsd.org> Subject: Re: RFC: Change mtree nsec handling? Message-ID: <68253.1233350348@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 30 Jan 2009 22:30:33 %2B0200." <20090130203033.GB52415@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20090130203033.GB52415@deviant.kiev.zoral.com.ua>, Kostik Belousov writes: >> >>@@ -258,6 +259,8 @@ >> >> val = ep + 1; >> >> ip->st_mtimespec.tv_nsec >> >> = strtoul(val, &ep, 10); >> >>+ for (i = ep - val; i < 9; ++i) >> >>+ ip->st_mtimespec.tv_nsec *= 10; >> > >> > >> >Why is this bit needed ? >> > >> >> This is the part that converts 1233295862.000001 into >> 1000 nanoseconds (instead of 1 nanosecond). But that wouldn't happen, because no mtree file has that content. Either it has 1233295862.000001000 from the new %09d or it has 1233295862.1000 from the old %d Please leave this out, it can only cause problems. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?68253.1233350348>