Date: Wed, 16 Jan 2002 16:12:05 -0800 (PST) From: Alfred Perlstein <alfred@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.sbin/rpc.lockd lockd_lock.c Message-ID: <200201170012.g0H0C5v67884@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
alfred 2002/01/16 16:12:05 PST
Modified files:
usr.sbin/rpc.lockd lockd_lock.c
Log:
Fix boundry condition in lock management:
Alfred, I took a look at retry_blockingfilelocklist() and the
solution seemed simple enough. Please correct me if I am wrong.
It seems said routine doesn't take into account boundary conditions
when putting back file_lock entries into the blocked lock-list.
Specifically, it fails when the file_lock being put back is the
last element in the list, and when it is the only element in the
list. I've included a patch below.
Basically, it introduces another variable: pfl, which keeps track
of the list item before ifl. That way if nfl is NULL, ifl gets
inserted after pfl. If pfl is also NULL, then it gets inserted
at the head of the list (since it was the only element in the
list).
Submitted by: Mike Makonnen <mike_makonnen@yahoo.com>
Tested by: Thomas Quinot <thomas@cuivre.fr.eu.org>
Revision Changes Path
1.7 +13 -2 src/usr.sbin/rpc.lockd/lockd_lock.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201170012.g0H0C5v67884>