Date: Fri, 4 Oct 2013 08:31:21 +0100 From: Mark R V Murray <mark@grondar.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org, Mark Murray <markm@FreeBSD.org> Subject: Re: svn commit: r256042 - in projects/random_number_generator: share/examples/kld/random_adaptor sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe sys/dev/syscons sys/dev/... Message-ID: <B1C46E7D-F60D-44C0-8D12-862A4CEF8997@grondar.org> In-Reply-To: <20131004072327.GR41229@kib.kiev.ua> References: <201310040655.r946t6ZR038091@svn.freebsd.org> <20131004070521.GQ41229@kib.kiev.ua> <BD962DAD-3105-4C1A-8509-64ED26F09D81@grondar.org> <20131004072327.GR41229@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_0837B9C8-899D-414F-93F6-8B12E5F44FC8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 4 Oct 2013, at 08:23, Konstantin Belousov <kostikbel@gmail.com> = wrote: > On Fri, Oct 04, 2013 at 08:09:48AM +0100, Mark R V Murray wrote: >>=20 >> On 4 Oct 2013, at 08:05, Konstantin Belousov <kostikbel@gmail.com> = wrote: >>=20 >>> On Fri, Oct 04, 2013 at 06:55:06AM +0000, Mark Murray wrote: >>>> #ifdef __amd64__ >>>> - ".byte\t0x48,0x0f,0xc7,0xf0\n\t" /* rdrand %rax */ >>>> + "rdrand\t%%rax\n\t" >>>> "jnc\t1f\n\t" >>>> "movq\t%%rax,%1\n\t" >>>> "movl\t$8,%%eax\n" >>>> #else /* i386 */ >>>> - ".byte\t0x0f,0xc7,0xf0\n\t" /* rdrand %eax */ >>>> + "rdrand\t%%eax\n\t" >>>> "jnc\t1f\n\t" >>>> "movl\t%%eax,%1\n\t" >>>> "movl\t$4,%%eax\n" >>> This should break the build with the in-tree binutils, i.e. when gcc >>> is used. The same for the chunks of the VIA asm. >>=20 >> This is likely a case of me getting it wrong, but I thought we were = headed away from worrying about that? Or is that only in 11-current? If = so I'll revert that bit. >>=20 >=20 > I assure you about the infinite stream of complains if the build with = the > base gcc is broken on x86. It is not catched by tinderboxes, but = people > are fast to report. *Sigh* OK :-). I'll revert for 10 but not 11-Current. OK? :-P > Also, if changing the .byte to mnemonic, it makes sense to loose the > constraints and allow the compiler to generate direct store from = rdrand > to the target address. I.e., do something like this (not tested): > rdrand %1 > jnc 1f > movl $8,%%eax > 1: Thanks! M --=20 Mark R V Murray --Apple-Mail=_0837B9C8-899D-414F-93F6-8B12E5F44FC8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: GPGTools - http://gpgtools.org iQCVAwUBUk5uyd58vKOKE6LNAQopegP+LavLr7b6M4l3UzSijLcvabm55tpns8kH RdMYttIb67hgkHBC0Fa5R+hD2XVEAH7SnvcmQTCFN5YHpElbFsdx6nt5G5c/GVid LuxjuXmJsbNaJhwHFsnxLTWrCuypX3IA4sfzkelOXiIygX/chsknPodY6HK+jPYI G9Xyq9tVnYA= =Ym+J -----END PGP SIGNATURE----- --Apple-Mail=_0837B9C8-899D-414F-93F6-8B12E5F44FC8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B1C46E7D-F60D-44C0-8D12-862A4CEF8997>