Date: Thu, 07 Jun 2012 00:58:57 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: sbruno@FreeBSD.org, freebsd-stable@FreeBSD.org, Yamagi Burmeister <lists@yamagi.org>, seanbru@yahoo-inc.com Subject: Re: [stable 9] broken hwpstate calls Message-ID: <4FCFD2A1.60706@FreeBSD.org> In-Reply-To: <4FC7D464.20602@FreeBSD.org> References: <1337319129.2915.4.camel@powernoodle-l7> <4FB6765A.2050307@FreeBSD.org> <1337710214.2916.8.camel@powernoodle-l7.corp.yahoo.com> <20120525163653.b61a08e2.lists@yamagi.org> <4FBFA9A9.7020806@FreeBSD.org> <4FBFBD39.7000105@FreeBSD.org> <4FBFDFFB.9020501@FreeBSD.org> <4FBFE624.1020208@FreeBSD.org> <20120526090233.f638c1d2.lists@yamagi.org> <4FC0A3A1.80200@FreeBSD.org> <4FC7D464.20602@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 31/05/2012 23:28 Jung-uk Kim said the following: > It is simple but I don't like locking scheduler, binding CPU, and writing > the same MSR, multiple times for each core. Not sure if parse this. The MSR is _written_ /once/ for each core. (BTW, "locking scheduler" is not a completely accurate description of what thread_lock does) > Besides, it introduces more delay and you may be reading the correct > status because of that. :-P Having a separate reading pass does introduce more delay indeed. Reading the correct status is a good thing, OTOH. Why would anyone want to read incorrect status? (just want to note that "correct" and "expected" are different things) > If people really think checking MSRC001_0071[18:16] is unworthy for Well, "other people" hasn't demonstrated/proved/convinced yet that it is worthy > Bulldozer, I prefer skipping status check That's what I suggested from the very start. > but I disagree with this patch. Since I am not invested in this issue (I am not affected by the problem and I do not have any personal attachment to the code in question), I will just defer any decision to those who do care about the problem. I hope that a fix will be provided in the end. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FCFD2A1.60706>