Date: Sat, 6 Nov 1999 11:23:07 +0100 (MET) From: Gerard Roudier <groudier@club-internet.fr> To: Ollivier Robert <roberto@keltia.freenix.fr> Cc: scsi@FreeBSD.ORG Subject: Re: SYM driver available for -stable Message-ID: <Pine.LNX.3.95.991106110547.349A-100000@localhost> In-Reply-To: <19991106010103.A2215@keltia.freenix.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Nov 1999, Ollivier Robert wrote: > Gerard Roudier disait : > > sym_conf.h file. You may edit this file, define SYMSETUP_SCSI_LED to 1 = and > > let us know if the 810a now is just fine for your next Christmas tree. = :)=20 >=20 > Doesn't seem to make any difference. The light (for the first controller = that > is the 875) is still on permanently. Here is a diff. I haven't checked that the LED handling is now OK since my box is lacking of available LEDs, but gave a try with 3.3 to check the driver hasn't been affected. Btw, the define to 1 of SYMSETUP_SCSI_LED is also required if any of your controller hasn't SYMBIOS NVRAM format detected by the driver. Reason is that only controllers that are compatible with SYMBIOS SDMS are guaranteed about assumption of LED handling through GPIO0 writing being actually safe since SDMS makes this assumption too. --- /tmp/SYM-0.9.0-19991024/sym_hipd.c=09Sun Oct 24 14:32:15 1999 +++ ./sym_hipd.c=09Sat Nov 6 10:52:20 1999 @@ -56,7 +56,7 @@ * SUCH DAMAGE. */ =20 -#define SYM_DRIVER_NAME=09"sym-0.9.0-19991024" +#define SYM_DRIVER_NAME=09"sym-0.9.1-19991106" =20 #include <pci.h> #include <stddef.h>=09/* For offsetof */ @@ -9942,7 +9942,7 @@ =09np->scripth0->pm0_data_addr[0] =3D cpu_to_scr(SCRIPT_BA(np,pm0_data)); =09np->scripth0->pm1_data_addr[0] =3D cpu_to_scr(SCRIPT_BA(np,pm1_data)); =20 -#ifdef=09SYM_OPT_LED0 + =09/* =09 * Still some for LED support. =09 */ @@ -9954,7 +9954,7 @@ =09=09np->script0->start[0] =3D =09=09=09=09cpu_to_scr(SCR_REG_REG(gpreg, SCR_AND, 0xfe)); =09} -#endif + =09/* =09 * Load SCNTL4 on reselection for the C10. =09 */ ---------------------- Cut Here -------------------------- As you can see, the C code that patches the SCRIPTS for the LED handling was conditionnaly compiled. Reason is that I changed my mind about the way to set-up the LED handling and forgot to remove the corresponding #ifdef/#endif. G=E9rard. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.3.95.991106110547.349A-100000>