Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Feb 2021 19:02:11 GMT
From:      Allan Jude <allanjude@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 922cf8ac43ad - main - Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Message-ID:  <202102161902.11GJ2Bmm042927@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by allanjude:

URL: https://cgit.FreeBSD.org/src/commit/?id=922cf8ac43adc9983f9a9e05cfd838306c1ef483

commit 922cf8ac43adc9983f9a9e05cfd838306c1ef483
Author:     Allan Jude <allanjude@FreeBSD.org>
AuthorDate: 2021-02-14 18:39:09 +0000
Commit:     Allan Jude <allanjude@FreeBSD.org>
CommitDate: 2021-02-16 19:02:00 +0000

    Use iflib_if_init_locked() during media change instead of iflib_init_locked().
    
    iflib_init_locked() assumes that iflib_stop() has been called, however,
    it is not called for media changes.
    iflib_if_init_locked() calls stop then init, so fixes the problem.
    
    PR:     253473
    MFC after:      3 days
    Reviewed by:    markj
    Sponsored by:   Juniper Networks, Inc., Klara, Inc.
    Differential Revision:  https://reviews.freebsd.org/D28667
---
 sys/net/iflib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/net/iflib.c b/sys/net/iflib.c
index cce56d0e7335..a33ddbe5b8ae 100644
--- a/sys/net/iflib.c
+++ b/sys/net/iflib.c
@@ -2503,7 +2503,7 @@ iflib_media_change(if_t ifp)
 
 	CTX_LOCK(ctx);
 	if ((err = IFDI_MEDIA_CHANGE(ctx)) == 0)
-		iflib_init_locked(ctx);
+		iflib_if_init_locked(ctx);
 	CTX_UNLOCK(ctx);
 	return (err);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102161902.11GJ2Bmm042927>