Date: Fri, 04 Jan 2013 10:30:13 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: gjb@FreeBSD.org Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, jgh@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r309910 - head/textproc/docproj Message-ID: <20130104.103013.1716297184205635398.hrs@allbsd.org> In-Reply-To: <20130104010502.GB21652@glenbarber.us> References: <201301040042.r040g3cj017454@svn.freebsd.org> <CAMuy=%2BiD9Rfj1LfUM2EO=Ev4pyDXYVdfwNh6g%2BdGXAdiq3g00g@mail.gmail.com> <20130104010502.GB21652@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Fri_Jan__4_10_30_13_2013_533)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber <gjb@FreeBSD.org> wrote in <20130104010502.GB21652@glenbarber.us>: gj> On Thu, Jan 03, 2013 at 05:02:01PM -0800, Jason Helfman wrote: gj> > > Log: gj> > > Revert previous commit. The more correct solution to this port gj> > > is to convert to the new options framework. gj> > > gj> > [...] gj> > gj> > Not sure why this was reverted. If this is built as a package on pointyhat, gj> > it would've remained WITH_JADETEX=yes per PACKAGE_BUILDING. That is, if I gj> > am understanding the discussion correctly. gj> gj> You are correct. However, the fact that files/JADETEX is not consistent gj> with the behavior if WITH_JADETEX is not set needs to be corrected, too. gj> So the better solution is to update this to the new options framework, gj> which is long overdue. FYI, setting YES by default for release package build, and null and display a warning in "make install" are the intentional behavior because people who blindly install textproc/docproj port tend to complain about "PDF version does not build" or "dependency is too large". This is why simply "make install" does not work. The reason why it is not "no by default" is that it causes inconsistency between pkg_add and make install (actually all of docproj* packages have jadetex dependency). One has to choose either, anyway. $JADETEX knob is a hack added back in the era when there was no OPTIONS, so converting it to OPTIONS would be more user-friendly. However, setting the default value is still a separate topic. "no" is harmful in terms of inconsistency with the pre-built package, and people will complain even if it is "yes" by default. For this reason, we have textproc/docproj-jadetex, textproc/docproj-nojadetex, and textproc/docproj with no default WITH_JADETEX. These are redundant and a bit messy due to historical reasons and they can be reconstructed into the two in a cleaner way, but if we want to change them, it should be done in whole. -- Hiroki ----Security_Multipart(Fri_Jan__4_10_30_13_2013_533)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlDmMKUACgkQTyzT2CeTzy3/qwCfcJ6P0zg6g/m1yqUHhavA96MU +nUAnRg0qfsfymWWBpzmMMjYnWVhywXy =jO2J -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Jan__4_10_30_13_2013_533)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130104.103013.1716297184205635398.hrs>