Date: Thu, 18 May 2017 02:45:46 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r318400 - head/sbin/ipfw Message-ID: <201705180945.v4I9jkTP065429@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <72e5d765-dfd5-dd65-b8f1-9d5524cde366@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
-- Start of PGP signed section. [ Charset UTF-8 unsupported, converting... ] > On 18.05.2017 03:49, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > >> Author: ae > >> Date: Wed May 17 10:56:22 2017 > >> New Revision: 318400 > >> URL: https://svnweb.freebsd.org/changeset/base/318400 > >> > >> Log: > >> Allow zero port specification in table entries with type flow. > >> > >> PR: 217620 > >> MFC after: 1 week > >> > >> Modified: > >> head/sbin/ipfw/tables.c > >> > >> Modified: head/sbin/ipfw/tables.c > >> ============================================================================== > >> --- head/sbin/ipfw/tables.c Wed May 17 09:04:09 2017 (r318399) > >> +++ head/sbin/ipfw/tables.c Wed May 17 10:56:22 2017 (r318400) > >> @@ -1260,16 +1260,14 @@ tentry_fill_key_type(char *arg, ipfw_obj > >> if ((p = strchr(arg, ',')) != NULL) > >> *p++ = '\0'; > >> > >> - if ((port = htons(strtol(arg, NULL, 10))) == 0) { > >> + port = htons(strtol(arg, &pp, 10)); > > ^^^ > > Can this be converted to a sizeof(foo) somehow? > > Constants like this are typically bad style and lead to bugs. > > This means that decimal number is expected in the string. > Not sure what bugs this can lead to. Ignore me, my brain was reading strtok as strncpy and expecting the third argument to be length limit. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201705180945.v4I9jkTP065429>