Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Apr 2018 23:06:50 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Oliver Pinter <oliver.pinter@hardenedbsd.org>
Cc:        John Baldwin <jhb@freebsd.org>, Ed Maste <emaste@freebsd.org>, Antoine Brodin <antoine@freebsd.org>, src-committers <src-committers@freebsd.org>, re <re@freebsd.org>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-11@freebsd.org, Mark Linimon <linimon@lonesome.com>
Subject:   Re: svn commit: r331838 - in stable/11: . contrib/compiler-rt/include/sanitizer contrib/compiler-rt/include/xray contrib/compiler-rt/lib/BlocksRuntime contrib/compiler-rt/lib/asan contrib/compiler-rt/l...
Message-ID:  <9DB407A8-8A6E-4F79-A5B3-5ED26AF37EEF@FreeBSD.org>
In-Reply-To: <CAPQ4ffsmkdDSuozhuXeUV_aAHZDXBTQHBVvh7kZ=_Zu=tyjx8A@mail.gmail.com>
References:  <201803311138.w2VBcKHP014025@repo.freebsd.org> <20180331184109.GA23589@lonesome.com> <CAPyFy2DL3Acp6DanoZBZm57XWhiujtM0os9Yau6spe%2Bhdzn8Gg@mail.gmail.com> <2526702.9M648BMneK@ralph.baldwin.cx> <CAPQ4ffsmkdDSuozhuXeUV_aAHZDXBTQHBVvh7kZ=_Zu=tyjx8A@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_59E2B4E0-1F75-4305-9172-726B1C2294A3
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 6 Apr 2018, at 21:00, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote:
> 
> On 4/6/18, John Baldwin <jhb@freebsd.org> wrote:
>> On Monday, April 02, 2018 12:27:47 PM Ed Maste wrote:
>>> On 31 March 2018 at 14:41, Mark Linimon <linimon@lonesome.com> wrote:
>>> This is the most important point of this discussion: we do need to
>>> ensure there's good communication and coordination between teams where
>>> dependencies like this exist. I'll take the blame here: Dimitry asked
>>> me about merging the Clang update to stable/11 and I agreed that it
>>> was reasonable to merge sooner rather than later to have as much lead
>>> time as possible before the 11.2 process starts. I also assumed that
>>> outstanding Clang 6 issues in ports were farther along in being
>>> addressed.
>>> 
>>> The key lesson from this discussion is that for significant commits
>>> and merges like this one we should make sure to always have sufficient
>>> advance notice.
>> 
>> Is this driven by -mretpoline?
> 
> Don't think so since it requires LLD as linker.

You can use lld on 11, but it isn't the default.


> The LLVM 5 which was already
> part of the 11-stable has the retpoline option. See r331219.

Indeed, r331219 contains backports (from upstream) for llvm, clang *and*
lld.  If you want to make use of -mretpoline, you should also pass
-fuse-ld=lld on the command line.


> From other side, I like to see a newer compiler sets in the recent
> releases, because
> there are lot of performance improvements and other fixes.

That is certainly the case, the flip side is that there are always some
new bugs, regressions and newly added warnings.  Having the default C++
dialect bumped is really an anomaly, this won't happen every upstream
release. :)

-Dimitry


--Apple-Mail=_59E2B4E0-1F75-4305-9172-726B1C2294A3
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWsfhagAKCRCwXqMKLiCW
o1KkAKDuBRPEESSzWrVU1iq3IRWYFja7nwCfXTrNI0vMPx2R15vCoJcdJqBQAq8=
=gktQ
-----END PGP SIGNATURE-----

--Apple-Mail=_59E2B4E0-1F75-4305-9172-726B1C2294A3--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9DB407A8-8A6E-4F79-A5B3-5ED26AF37EEF>