Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 14 Sep 2016 16:34:52 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r305812 - head/usr.sbin/fifolog/lib
Message-ID:  <201609141634.u8EGYqIJ012426@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: pfg
Date: Wed Sep 14 16:34:52 2016
New Revision: 305812
URL: https://svnweb.freebsd.org/changeset/base/305812

Log:
  fifolog(1): invert order of calloc(3) arguments.
  
  The second argment to calloc(3) should be the size, make it so.
  
  While here be a little bit more cautious in fifolog_reader_open()
  to protect in the unlikely event of an overflowed allocation.
  
  MFC after:	3 weeks

Modified:
  head/usr.sbin/fifolog/lib/fifolog_create.c
  head/usr.sbin/fifolog/lib/fifolog_reader.c
  head/usr.sbin/fifolog/lib/fifolog_write_poll.c
  head/usr.sbin/fifolog/lib/miniobj.h

Modified: head/usr.sbin/fifolog/lib/fifolog_create.c
==============================================================================
--- head/usr.sbin/fifolog/lib/fifolog_create.c	Wed Sep 14 16:08:23 2016	(r305811)
+++ head/usr.sbin/fifolog/lib/fifolog_create.c	Wed Sep 14 16:34:52 2016	(r305812)
@@ -97,7 +97,7 @@ fifolog_create(const char *fn, off_t siz
 	if (S_ISREG(st.st_mode) && ftruncate(fd, size) < 0)
 		return ("Could not ftrunc");
 
-	buf = calloc(recsize, 1);
+	buf = calloc(1, recsize);
 	if (buf == NULL)
 		return ("Could not malloc");
 

Modified: head/usr.sbin/fifolog/lib/fifolog_reader.c
==============================================================================
--- head/usr.sbin/fifolog/lib/fifolog_reader.c	Wed Sep 14 16:08:23 2016	(r305811)
+++ head/usr.sbin/fifolog/lib/fifolog_reader.c	Wed Sep 14 16:34:52 2016	(r305812)
@@ -67,10 +67,10 @@ fifolog_reader_open(const char *fname)
 	if (retval != NULL)
 		err(1, "%s", retval);
 
-	fr->olen = fr->ff->recsize * 16;
-	fr->obuf = calloc(fr->olen, 1);
+	fr->obuf = calloc(16, fr->ff->recsize);
 	if (fr->obuf == NULL)
 		err(1, "Cannot malloc");
+	fr->olen = fr->ff->recsize * 16;
 
 	i = inflateInit(fr->ff->zs);
 	assert(i == Z_OK);

Modified: head/usr.sbin/fifolog/lib/fifolog_write_poll.c
==============================================================================
--- head/usr.sbin/fifolog/lib/fifolog_write_poll.c	Wed Sep 14 16:08:23 2016	(r305811)
+++ head/usr.sbin/fifolog/lib/fifolog_write_poll.c	Wed Sep 14 16:34:52 2016	(r305812)
@@ -45,7 +45,7 @@
 static int fifolog_write_gzip(struct fifolog_writer *f, time_t now);
 
 #define ALLOC(ptr, size) do {                   \
-	(*(ptr)) = calloc(size, 1);             \
+	(*(ptr)) = calloc(1, size);             \
 	assert(*(ptr) != NULL);                 \
 } while (0)
 

Modified: head/usr.sbin/fifolog/lib/miniobj.h
==============================================================================
--- head/usr.sbin/fifolog/lib/miniobj.h	Wed Sep 14 16:08:23 2016	(r305811)
+++ head/usr.sbin/fifolog/lib/miniobj.h	Wed Sep 14 16:34:52 2016	(r305812)
@@ -28,7 +28,7 @@
 
 #define ALLOC_OBJ(to, type_magic)					\
 	do {								\
-		(to) = calloc(sizeof *(to), 1);				\
+		(to) = calloc(1, sizeof *(to));				\
 		if ((to) != NULL)					\
 			(to)->magic = (type_magic);			\
 	} while (0)

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201609141634.u8EGYqIJ012426>