Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Jun 2012 16:41:32 -0700
From:      Jason Helfman <jgh@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        bkoenig@alpha-tierchen.de
Subject:   ports/169222: [PATCH] sysutils/mono-kmod: fix usage of ${SRC_BASE} before it is defined
Message-ID:  <1340062892.942928.17633.nullmailer@experts-exchange.com>
Resent-Message-ID: <201206182350.q5INoM8I036069@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         169222
>Category:       ports
>Synopsis:       [PATCH] sysutils/mono-kmod: fix usage of ${SRC_BASE} before it is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 18 23:50:21 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jason Helfman
>Release:        FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr  9 21:23:18 UTC
>Description:
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

Port maintainer (bkoenig@alpha-tierchen.de) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- mono-kmod-20070416.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/sysutils/mono-kmod/Makefile,v
retrieving revision 1.6
diff -u -r1.6 Makefile
--- Makefile	6 Jan 2009 17:59:28 -0000	1.6
+++ Makefile	18 Jun 2012 23:42:24 -0000
@@ -20,6 +20,8 @@
 SUB_FILES=	pkg-message
 PKGMESSAGE=	${WRKDIR}/pkg-message
 
+.include <bsd.port.pre.mk>
+
 SRC_BASE?=	/usr/src
 
 PLIST_SUB=	KMODDIR=${KMODDIR}
@@ -29,8 +31,6 @@
 PLIST_FILES+=	mono.ko
 PLIST_FILES+=	"@unexec kldxref ${KMODDIR}"
 
-.include <bsd.port.pre.mk>
-
 .if !exists(${SRC_BASE}/sys/Makefile)
 IGNORE=		requires kernel source to be installed
 .endif
--- mono-kmod-20070416.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340062892.942928.17633.nullmailer>