Date: Tue, 12 Nov 2013 10:29:32 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: d@delphij.net Cc: freebsd-x11@freebsd.org, freebsd-current@freebsd.org, neel@neelc.org Subject: Re: [PATCH] Haswell Kernel Mode Setting Message-ID: <20131112082932.GU59496@kib.kiev.ua> In-Reply-To: <52816A9A.4050305@delphij.net> References: <aa01f8714674fb97f0aa96f9bab90968@mail.neelc.org> <52816A9A.4050305@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--AgFe1kDvcheJvJOe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 11, 2013 at 03:39:06PM -0800, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 >=20 > On 11/11/13 14:29, Neel Chauhan wrote: > > Sorry if I sent a similar patch before. It didn't get accepted so I > > am sending one now. Enjoy. >=20 > What does "didn't get accepted" mean? :) Since this looks like a > PCI-ID only change that do not affect other existing hardware, if it's > not an explicit objection from a reviewer, I think it's Okay to just > go ahead and commit the change after a reasonable timeout instead of > waiting indefinitely. I very much doubt that this patch works. More, I believe that it was not tested at all. Talking about the trivially obvious things, the PGTT handling must be updated since page tables have different format comparing with Ivy, there are some changes to ring dispatching, and lot of changes in the display pipeline. All this is missing from the patch. Oh, and the Series 8 chipset PCH detection is missing. I probably should stop now. HSW support is much more than just adding the Ids, I am (slowly) starting the work on importing the Linux updates. --AgFe1kDvcheJvJOe Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSgebrAAoJEJDCuSvBvK1BvzEP/0y6MHsO623n6Zzy2nx/3S4W mNhmexgKBmVj7bBil59W7AeesBwZLI24OFYIcvP5vjBnkPOK9jZvsHDcWYbbSjlX HKxZRzU2nf/eszr7ziD5vul3D/wciWBSjtt/0U9AVr/o1sCV/WZakNxz/lWt21hp XLu2/u7N9bb/2phdz+JP5FicEMWxJBaOEwyXkU8liklTd5/fE/Fvjah+Elr20xIr 2FGB0V0Qm7J+c1seZuRLyGQEeRRyYjtxl5T1PO5sptCDhNIs1zXJt0MJvF9bcNJg /DX5xtvDLc8H1yoRuAFrHH0/m09hiDrAlSOQcC/VVjaXAmI0kabM9zAbOIjmT71E LCR5Vn2OTlTyiST2OhRS6H6ysjsRMDW+iWQhH1ncov4myg6fICQl4vO/81hO2Cmp hcxrzGkwgr43lFxgz1NGnWE3DeGRTqJDZgf2lJbjnI3udbhGHkS6GInbDz+ebh61 EEG1gro6w2Q0PDehFBQJPj0TQlbYiFXCoCnM3C7Xg3n0dTZn7IRM6MDb5bpGo3qW 5kK6zpR6P0l+orubtfFv59WPE1ZBngz5i/KlFH6aBD/SIn2A5m21uCp/Pj4s0HqD 23rDxzZcSyH4KGl5kWcj/b4b0j2DCmgX3qJGapfrw+4B5Vi+UJaQ/HX1H9H/rPBN 6Li4u4C1539eTczv1sLZ =YkUS -----END PGP SIGNATURE----- --AgFe1kDvcheJvJOe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131112082932.GU59496>