Date: Mon, 11 Apr 2005 20:48:06 +0200 From: Florent Thoumie <flz@xbsd.org> To: Kris Kennaway <kris@obsecurity.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/archivers/gzip Makefile ports/archivers/ucl Makefile ports/archivers/dact Makefile ports/archivers/star Makefile ports/archivers/arj Makefile ports/archivers/tardy ... Message-ID: <1113245286.934.21.camel@cream.xbsd.org> In-Reply-To: <20050411184433.GA69339@xor.obsecurity.org> References: <200504110804.j3B84fNs060515@repoman.freebsd.org> <20050411084210.GA2339@xor.obsecurity.org> <20050411180839.GA32740@dragon.NUXI.org> <1113243303.934.14.camel@cream.xbsd.org> <20050411182133.GA62598@xor.obsecurity.org> <1113244611.934.19.camel@cream.xbsd.org> <20050411184433.GA69339@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-1AuMxqP4czsoM6qeKeXB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Le Monday 11 April 2005 =E0 11:44 -0700, Kris Kennaway a =E9crit : > On Mon, Apr 11, 2005 at 08:36:51PM +0200, Florent Thoumie wrote: > > Le Monday 11 April 2005 ? 11:21 -0700, Kris Kennaway a ?crit : > > > On Mon, Apr 11, 2005 at 08:15:03PM +0200, Florent Thoumie wrote: > > > > Le Monday 11 April 2005 ? 11:08 -0700, David O'Brien a ?crit : > > > > > On Mon, Apr 11, 2005 at 01:42:11AM -0700, Kris Kennaway wrote: > > > > > > On Mon, Apr 11, 2005 at 08:04:41AM +0000, David E. O'Brien wrot= e: > > > > > > > obrien 2005-04-11 08:04:41 UTC > > > > > > >=20 > > > > > > > FreeBSD ports repository > > > > > > >=20 > > > > > > > Modified files: > > > > > > > archivers/gzip Makefile=20 > > > > > > > archivers/ucl Makefile=20 > > > > > >=20 > > > > > > Please back this out. > > > > >=20 > > > > > Will do. > > > >=20 > > > > I have fixed almost all ports and ready to commit. > > > >=20 > > > > I'd like to be sure not facing portmgr decision to backout the=20 > > > > commit. > > > >=20 > > > > Note: I've already fixed some, haven't seen this mail from Kris. > > >=20 > > > What I'd like is for everything to be backed out except for those > > > ports that have been since fixed by you and others. That way your > > > work isn't undone. > >=20 > > They're all fixed, but not all committed. > >=20 > > I haven't spent too much time on this, so that's not a big deal > > but as Adam stated, he didn't break much ports in comparison=20 > > of how many he touched. Plus, the MACHINE_ARCH -> ARCH isn't=20 > > only style change. > >=20 > > Btw, it's up to you. >=20 > The first issue here is timing. As reminded in my original email > there are not supposed to be any sweeping commits during the ports > slush. The second issue is the amount of breakage that happened here > due to untested changes and apparent lack of visual review of the diff > prior to committing. I believe that most of that will be caught by a > simple review of the diff, which you've probably completed already. > I'll be happy for you to commit the rest of the changes after the > slush ends, but for now we need to go back to a relatively clean > slate. Sure, no problem. I'll submit patches to David so he can do this by himself (or=20 I'll do). --=20 Florent Thoumie flz@xbsd.org --=-1AuMxqP4czsoM6qeKeXB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQBCWsZmMxEkbVFH3PQRAo5bAJ9RJPnuek0nSsEA7e5P2adHy57XCACferr9 9Ep6l8kCsosyotmFucFqnow= =FKVx -----END PGP SIGNATURE----- --=-1AuMxqP4czsoM6qeKeXB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1113245286.934.21.camel>