Date: Wed, 24 Jan 2001 10:45:47 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Alfred Perlstein <bright@wintelcom.net> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/linux linux_machdep.c linux_sysvec Message-ID: <XFMail.010124104547.jhb@FreeBSD.org> In-Reply-To: <20010124093655.W26076@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24-Jan-01 Alfred Perlstein wrote: > * John Baldwin <jhb@FreeBSD.org> [010124 02:28] wrote: >> jhb 2001/01/24 02:26:13 PST >> >> Modified files: >> sys/alpha/linux linux_machdep.c linux_sysvec.c >> Log: >> Proc locking. > > This looks like another natural race condition: > > int p_sigparent; /* (c) Signal to parent on > exit. */ > > Can't int assignments be assumed to be atomic? > > + PROC_LOCK(p); > p2->p_sigparent = exit_signal; > + PROC_UNLOCK(p); Well, I b0rked that one (p2 not p). To fix the race, what probably should happen is what we do with kthreads in kthread_create: create the process with RFSTOPPED, and don't makea it runnable until we are done futzing around with it. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010124104547.jhb>