Date: Tue, 9 Jan 2018 21:54:37 +0000 (UTC) From: Jeff Roberson <jeff@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r327749 - user/jeff/numa/sys/dev/acpica Message-ID: <201801092154.w09Lsb69024433@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jeff Date: Tue Jan 9 21:54:37 2018 New Revision: 327749 URL: https://svnweb.freebsd.org/changeset/base/327749 Log: Review feedback from jhb. Cleaner initialization. Don't leak a tag on error. Modified: user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c Modified: user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c ============================================================================== --- user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c Tue Jan 9 21:37:35 2018 (r327748) +++ user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c Tue Jan 9 21:54:37 2018 (r327749) @@ -542,7 +542,7 @@ acpi_pcib_acpi_attach(device_t dev) acpi_pcib_fetch_prt(dev, &sc->ap_prt); error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, - PCI_DMA_BOUNDARY, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, + 0, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXSIZE, BUS_SPACE_UNRESTRICTED, BUS_SPACE_MAXSIZE, 0, NULL, NULL, &sc->ap_dma_tag); if (error != 0) @@ -555,6 +555,8 @@ acpi_pcib_acpi_attach(device_t dev) bus_generic_probe(dev); if (device_add_child(dev, "pci", -1) == NULL) { + bus_dma_tag_destroy(sc->ap_dma_tag); + sc->ap_dma_tag = NULL; error = ENXIO; goto errout; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801092154.w09Lsb69024433>