Date: Thu, 06 Jun 2013 18:47:01 +0200 From: Nikos Vassiliadis <nvass@gmx.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Mikolaj Golub <trociny@FreeBSD.org>, "Bjoern A. Zeeb" <bz@FreeBSD.org>, freebsd-jail@freebsd.org, freebsd-virtualization@freebsd.org, freebsd-pf@freebsd.org Subject: Re: pf + vimage patch Message-ID: <51B0BD05.60102@gmx.com> In-Reply-To: <20130606122855.GC14667@glebius.int.ru> References: <51AC84EE.6020009@gmx.com> <20130605085219.GA53217@gmail.com> <51B065F5.4080209@gmx.com> <20130606122409.GA10459@gmail.com> <20130606122855.GC14667@glebius.int.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/06/2013 02:28 PM, Gleb Smirnoff wrote: > M> > module unload is broken:( Maybe it can be fixed at a (bit) later date? > M> > M> I don't think Gleb will be happy with this. Some time ago he removed > M> some vimage related stuff to prevent crashing on module unload (see > M> r229849). Actually your patch looks like a partial revert of that > M> commit. So I think you need to think about this issue from start. At > M> least it should not crash non-vimage kernel and there should be > M> understanding how to fix it for vimage kernel. Your approach with > M> keeping only one purge thread might make it simpler. Unloading should be simple in the non-vimage case as well - I think. > True. It is very much appreciated that you are working on vimage + pf, > but breaking module unload isn't an option. > > When hacking on a part of kernel, having a possibility to avoid a reboot > after each compile is very important. > Good point. Thank you both for your comments. Nikos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51B0BD05.60102>