Date: Wed, 25 Sep 2019 15:13:09 -0400 From: Ed Maste <emaste@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r351319 - in head/usr.sbin/makefs: ffs msdos Message-ID: <CAPyFy2Dn%2BrRYmrXMteBpUcxZurJhL5cgahs6dT=_=L20kLncGg@mail.gmail.com> In-Reply-To: <20190830140337.D1405@besplex.bde.org> References: <201908210145.x7L1jU3x072180@repo.freebsd.org> <20190830140337.D1405@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 30 Aug 2019 at 00:29, Bruce Evans <brde@optusnet.com.au> wrote: > > On Wed, 21 Aug 2019, Ed Maste wrote: > > > Author: emaste > > Date: Wed Aug 21 01:45:29 2019 > > New Revision: 351319 > > URL: https://svnweb.freebsd.org/changeset/base/351319 > > > > Log: > > makefs: use `char *` not `void *` for buf b_data, drop casts in msdos > > > > (The kernel uses caddr_t.) > > This is much better than churning the copy of the working code. My eventual goal is to converge on a shared copy of these files, generally moving to what is already done in the kernel's implementation. If there's reasonable clean up or improvements to be made in the kernel code I'm interested in doing so, but I'm not really sure what to do with the caddr_ts there yet. I see that NetBSD removed all uses of caddr_t.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Dn%2BrRYmrXMteBpUcxZurJhL5cgahs6dT=_=L20kLncGg>