Date: Tue, 31 Mar 2009 03:20:31 GMT From: soflare <soflare@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/133235: Process SIOCDLIFADDR command incorrectly in in_control() Message-ID: <200903310320.n2V3KVM8093009@www.freebsd.org> Resent-Message-ID: <200903310330.n2V3U3xv081928@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 133235 >Category: kern >Synopsis: Process SIOCDLIFADDR command incorrectly in in_control() >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 31 03:30:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: soflare >Release: 7.0-RELEASE >Organization: >Environment: FreeBSD liangzy-fbsd7.home.net 7.1-RELEASE FreeBSD 7.1-RELEASE #12: Fri Mar 20 21:19:12 UTC 2009 root@liangzy-fbsd7.arraynetworks.com.cn:/usr/obj/usr/src/sys/SOLAR i386 >Description: Can't delete an alias by using SIOCDLIFADDR command. Always return EADDRNOTAVAIL. >How-To-Repeat: >Fix: Patch attached with submission follows: --- in.c 2009-03-20 21:09:46.000000000 +0000 +++ src/sys/netinet/in.c 2009-03-20 21:15:35.000000000 +0000 @@ -634,11 +634,13 @@ in_lifaddr_ioctl(struct socket *so, u_lo } TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) { - if (ifa->ifa_addr->sa_family != AF_INET6) + struct sockaddr_in *sa; + sa=(struct sockaddr_in *)ifa->ifa_addr; + if (ifa->ifa_addr->sa_family != AF_INET) continue; if (match.s_addr == 0) break; - candidate.s_addr = ((struct sockaddr_in *)&ifa->ifa_addr)->sin_addr.s_addr; + candidate.s_addr = sa->sin_addr.s_addr; candidate.s_addr &= mask.s_addr; if (candidate.s_addr == match.s_addr) break; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903310320.n2V3KVM8093009>