Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Nov 2013 18:29:15 -0500
From:      Julio Merino <julio@meroh.net>
To:        "Simon J. Gerraty" <sjg@juniper.net>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r258285 - in head/lib/atf: libatf-c++/tests libatf-c/tests tests/test-programs
Message-ID:  <CADyfeQV9rMxQY8GoMHS=K7CrLDtUHR-o0qpK-Eho3hT0pL%2BDWA@mail.gmail.com>
In-Reply-To: <20131119003307.9E25A5807E@chaos.jnpr.net>
References:  <201311172312.rAHNCtOY010186@svn.freebsd.org> <20131119003307.9E25A5807E@chaos.jnpr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 18, 2013 at 7:33 PM, Simon J. Gerraty <sjg@juniper.net> wrote:
>
> On Sun, 17 Nov 2013 23:12:55 +0000, Julio Merino writes:
>>  I am not sure how this ever worked before given that manual inspection
>>  of bsd.progs.mk clearly shows that the expected character between the
>>  two components is a dot and not an underscore... but I suspect the
>
> Actually . or _ worked, until recently.

I think only supporting one form is better in the name of simplicity.

> Will fix.

Garrett also mentioned to me that we should not be required to
explicitly set SRCS.*: when building various programs, each of them
should be able to determine a reasonable value for this variable on
its own. In other words, what I did in r258298 should probably not be
required. What do you think?

-- 
Julio Merino / @jmmv



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADyfeQV9rMxQY8GoMHS=K7CrLDtUHR-o0qpK-Eho3hT0pL%2BDWA>