Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 May 2014 21:35:42 +0300
From:      Lena@lena.kiev.ua
To:        freebsd-chromium@freebsd.org
Subject:   Re: Chromium 34.0.1847.132 Segmentation fault
Message-ID:  <20140522183542.GS16188@lena.kiev>
In-Reply-To: <20140522183300.GB789@lena.kiev>
References:  <CAHHLbRNKqK%2BwMQ=Zo54Uuc1Qm=g7QtGrP7Zix%2B%2BRUq_4erhoQg@mail.gmail.com> <20140520194707.GE13426@lena.kiev> <20140522183300.GB789@lena.kiev>

next in thread | previous in thread | raw e-mail | index | archive | help
> Build of 35.0.1916.114 with lang/gcc on i386 initially failed,
> patches similar to
> http://svnweb.freebsd.org/ports?view=revision&revision=353447
> attached.
> 
> 8.4-RELEASE i386 - the same segfault at start:
> 
> (gdb) bt
> #0  0x2e1c0f64 in getframeaddr () from /usr/local/lib/libexecinfo.so.1
> #1  0x2e1bcb21 in backtrace () from /usr/local/lib/libexecinfo.so.1
> #2  0x087f4e4a in std::string::_S_construct<char*> ()
> #3  0x08a70a11 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<__gnu_cxx::__normal_iterator<char*, std::string> > ()
> #4  0x089a9498 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<__gnu_cxx::__normal_iterator<char*, std::string> > ()
> #5  0x089a8a64 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<__gnu_cxx::__normal_iterator<char*, std::string> > ()
> #6  0x33ba0870 in ?? ()
> #7  0x318c2384 in ?? ()
> #8  0x00000000 in ?? ()
> (gdb)

Patches were stripped out by Mailman. Here they are:

--- media/cast/rtcp/rtcp.cc.orig	2014-05-14 22:23:34.000000000 +0300
+++ media/cast/rtcp/rtcp.cc	2014-05-22 14:16:27.000000000 +0300
@@ -362,7 +362,7 @@
   int64 rtp_time_diff_ms = rtp_timestamp_diff / frequency_khz;
 
   // Sanity check.
-  if (std::abs(rtp_time_diff_ms) > kMaxDiffSinceReceivedRtcpMs)
+  if (std::labs(rtp_time_diff_ms) > kMaxDiffSinceReceivedRtcpMs)
     return false;
 
   *rtp_timestamp_in_ticks = ConvertNtpToTimeTicks(last_received_ntp_seconds_,
--- net/quic/congestion_control/rtt_stats.cc.orig	2014-05-14 22:22:13.000000000 +0300
+++ net/quic/congestion_control/rtt_stats.cc	2014-05-22 11:22:18.000000000 +0300
@@ -63,7 +63,7 @@
   } else {
     mean_deviation_ = QuicTime::Delta::FromMicroseconds(
         kOneMinusBeta * mean_deviation_.ToMicroseconds() +
-        kBeta * std::abs(smoothed_rtt_.Subtract(rtt_sample).ToMicroseconds()));
+        kBeta * std::labs(smoothed_rtt_.Subtract(rtt_sample).ToMicroseconds()));
     smoothed_rtt_ = smoothed_rtt_.Multiply(kOneMinusAlpha).Add(
         rtt_sample.Multiply(kAlpha));
     DVLOG(1) << "Cubic; smoothed_rtt(us):" << smoothed_rtt_.ToMicroseconds()
--- third_party/webrtc/modules/video_coding/main/source/receiver.cc.orig	2014-05-14 22:24:36.000000000 +0300
+++ third_party/webrtc/modules/video_coding/main/source/receiver.cc	2014-05-22 11:31:18.000000000 +0300
@@ -158,12 +158,12 @@
   // Assume that render timing errors are due to changes in the video stream.
   if (next_render_time_ms < 0) {
     timing_error = true;
-  } else if (std::abs(next_render_time_ms - now_ms) > max_video_delay_ms_) {
+  } else if (std::labs(next_render_time_ms - now_ms) > max_video_delay_ms_) {
     WEBRTC_TRACE(webrtc::kTraceWarning, webrtc::kTraceVideoCoding,
                  VCMId(vcm_id_, receiver_id_),
                  "This frame is out of our delay bounds, resetting jitter "
                  "buffer: %d > %d",
-                 static_cast<int>(std::abs(next_render_time_ms - now_ms)),
+                 static_cast<int>(std::labs(next_render_time_ms - now_ms)),
                  max_video_delay_ms_);
     timing_error = true;
   } else if (static_cast<int>(timing_->TargetVideoDelay()) >



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140522183542.GS16188>