Date: Fri, 26 Aug 2016 17:58:28 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Dimitry Andric <dim@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org> Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang Message-ID: <CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg@mail.gmail.com> In-Reply-To: <A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org> References: <201608262256.u7QMuNaZ037409@repo.freebsd.org> <CAGHfRMCZ9Ma%2B9wfFJ%2BKFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com> <A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 26, 2016 at 4:39 PM, Dimitry Andric <dim@freebsd.org> wrote:
...
> I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the
> latter didn't work for builds which are started during bootstrap-tools.
> So I locally reverted all these changes before committing this WIP.
>
> That said, ${SRCTOP} makes it look a little nicer, but there are lots
> of other instances of using ../../.. in these Makefiles. It does not
> really bother me. :)
Can you use something like this instead to signal the "right intent",
and someday hopefully this will just work (tm) with a bit more effort?
Thanks,
-Ngie
# XXX: SRCTOP isn't available until Y stage in the build
SRCTOP?= ${.CURDIR:H:H}
LLVM_SRCS= ${SRCTOP}/contrib/llvm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg>