Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Oct 2002 16:13:27 +0200 (CEST)
From:      Palle Girgensohn <girgen@pingpong.net>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   bin/43975: share/sendmail/Makefile uses ${INSTALL} -d, breaks with -C
Message-ID:  <200210121413.g9CEDRFK041611@palle.girgensohn.se>

next in thread | raw e-mail | index | archive | help

>Number:         43975
>Category:       bin
>Synopsis:       share/sendmail/Makefile uses ${INSTALL} -d, breaks with -C
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 12 07:20:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Palle Girgensohn <girgen@pingpong.net>
>Release:        FreeBSD 4.7-RELEASE i386
>Organization:
PING PONG
>Environment:
System: FreeBSD palle.girgensohn.se 4.7-RC FreeBSD 4.7-RC #0: Sun Sep 29 17:21:22 CEST 2002     root@palle.girgensohn.se:/usr/local/obj/usr/src/sys/STORDATAN  i386

also applies to CURRENT, afaik.
	
>Description:
src/share/sendmail/Makefile uses ${INSTALL} ... -d
src/etc/default/make.conf recommends setting INSTALL/install -C ,
which I find a good thing.

Now, since fbsd-4.5.something (?), install -C -d ... fails (previously
it silently ignored the `-C'). So, using ${INSTALL} -d in src and
ports cannot be allowed anymore; instead we must either not use the
INSTALL var, i.e. `install -C', or do the mkdir; chmod; chown troika.

>How-To-Repeat:
# echo 'INSTALL=install -C' >> /etc/make.conf
# cd /usr/src
# make installworld

the only thing that fails is share/sendmail
>Fix:
This patch would be much appreciated:

Index: Makefile
===================================================================
RCS file: /usr/local/ncvs/src/share/sendmail/Makefile,v
retrieving revision 1.1.2.6
diff -u -u -r1.1.2.6 Makefile
--- Makefile	7 Aug 2002 16:31:51 -0000	1.1.2.6
+++ Makefile	12 Oct 2002 13:57:40 -0000
@@ -23,7 +23,9 @@
 
 copies::
 .for dir in ${CFDIRS}
-	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 755 -d ${DDIR}/${dir}
+	${MKDIR} ${DDIR}/${dir}
+	${CHMOD} 755 ${DDIR}/${dir}
+	${CHOWN} ${BINOWN}:${BINGRP} ${DDIR}/${dir}
 .endfor
 .for file in ${CFFILES}
 	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 444 ${SENDMAIL_DIR}/${file} ${DDIR}/${file}
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210121413.g9CEDRFK041611>