Date: Thu, 1 Jun 2017 17:16:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, Marcel Moolenaar <marcel@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, svn-src-all@FreeBSD.org, Brooks Davis <brooks@FreeBSD.org>, svn-src-head@FreeBSD.org, Ngie Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <20170601171642.GA601@FreeBSD.org> In-Reply-To: <84744.1496336318@kaos.jnpr.net> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <84744.1496336318@kaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote: > One option would be to store a sha256 hash of the result. > If the image generated by the test hashes to the correct value - you > pass. That should be preferred. Storing binary blobs in VCS is bad practice. > Of course if the test fails, you are completely in the dark as to > how/why. Not really: you checkout previous version (which produces correct hash) and store generated image for later inspection and diffing. > Is storing img-1x1-512-mbr.vmdk.gz any more palatable? This is barely acceptable, but only if image was zerofied/sparsed prior to compression. Also, the image should be of the minimal (sufficient) working size. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170601171642.GA601>