Date: Thu, 06 Dec 2007 23:20:30 +0100 From: Christoph Mallon <christoph.mallon@gmx.de> To: Kip Macy <kip.macy@gmail.com> Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, Kip Macy <kmacy@freebsd.org>, Bruce Evans <brde@optusnet.com.au> Subject: Re: cvs commit: src/sys/sys param.h Message-ID: <475875AE.6040900@gmx.de> In-Reply-To: <b1fa29170712061104i5cd14280t7033bca039bec3ff@mail.gmail.com> References: <200712060400.lB640xxi025146@repoman.freebsd.org> <20071206202639.N11122@delplex.bde.org> <b1fa29170712061104i5cd14280t7033bca039bec3ff@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Kip Macy wrote: > On Dec 6, 2007 2:25 AM, Bruce Evans <brde@optusnet.com.au> wrote: >> On Thu, 6 Dec 2007, Kip Macy wrote: >> >>> kmacy 2007-12-06 04:00:59 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/sys param.h >>> Log: >>> Respect the fact that the value a may be constant so cast to const uint8_t * >>> >>> Revision Changes Path >>> 1.318 +2 -2 src/sys/sys/param.h >> The correct fix is to back out 1.317. If not, at least spell `unsigned >> char' correctly and fix the other new style bug (a line longer than >> 80 characters from adding `const'). Using uint8_t is only a style bug >> since POSIX probably requires unsigned char to be the same as uint8_t. >> If unsigned char is larger than uint8_t, then revs.1.317-318 give >> undefined behaviour (aliasing bugs) and clearly broken behaviour (wrong >> divisor NBBY). These bugs are easy to avoid by using the correct >> spelling. >> > > I'm inclined to do whatever you say so long as my code works without a > substantial rewrite. However, can you please point me at where it says > uint8_t is not style(9) compliant? I think, he means that uint8_t is not necessarily the same type as unsigned char. In fact according to the C99 standard the type uint8_t does not necessarily exist (section 7.18.1.1). Christoph
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?475875AE.6040900>